test(linter/no-console): add more tests (#11878)

Add a few tests to `no-console` rule, to make sure it catches e.g. `console['log'](foo)`.

The test for `console[`lo\\x67`](foo)` ensures the correct operation of `ComputedMemberExpression::static_property_name` - that it uses `cooked` not `raw` for `TemplateLiteral`s.

Author: overlookmotel

crates/oxc_linter/src/rules/eslint/no_console.rs

@@ -213,6 +213,10 @@ fn test() {
         ("console.error(foo)", None, None),
         ("console.info(foo)", None, None),
         ("console.warn(foo)", None, None),
+        ("console['log'](foo)", None, None),
+        ("console[`log`](foo)", None, None),
+        ("console['lo\\x67'](foo)", None, None),
+        ("console[`lo\\x67`](foo)", None, None),
         ("console.log()", None, Some(serde_json::json!({ "env": { "browser": true}}))),
         ("console.log()", None, Some(serde_json::json!({ "globals": { "console": "off"}}))),
         ("console.log(foo)", Some(serde_json::json!([{ "allow": ["error"] }])), None),

crates/oxc_linter/src/snapshots/eslint_no_console.snap

@@ -43,6 +43,34 @@ source: crates/oxc_linter/src/tester.rs
    ╰────
   help: Delete this console statement.
 
+  ⚠ eslint(no-console): Unexpected console statement.
+   ╭─[no_console.tsx:1:1]
+ 1 │ console['log'](foo)
+   · ─────────────
+   ╰────
+  help: Delete this console statement.
+
+  ⚠ eslint(no-console): Unexpected console statement.
+   ╭─[no_console.tsx:1:1]
+ 1 │ console[`log`](foo)
+   · ─────────────
+   ╰────
+  help: Delete this console statement.
+
+  ⚠ eslint(no-console): Unexpected console statement.
+   ╭─[no_console.tsx:1:1]
+ 1 │ console['lo\x67'](foo)
+   · ────────────────
+   ╰────
+  help: Delete this console statement.
+
+  ⚠ eslint(no-console): Unexpected console statement.
+   ╭─[no_console.tsx:1:1]
+ 1 │ console[`lo\x67`](foo)
+   · ────────────────
+   ╰────
+  help: Delete this console statement.
+
   ⚠ eslint(no-console): Unexpected console statement.
    ╭─[no_console.tsx:1:1]
  1 │ console.log()