fix(formatter): add parentheses for TSUnionType inside TSArrayType (#13792)

Author: Sysix

crates/oxc_formatter/src/parentheses/ts_type.rs

@@ -14,6 +14,7 @@ impl<'a> NeedsParentheses<'a> for AstNode<'a, TSType<'a>> {
             AstNodes::TSFunctionType(it) => it.needs_parentheses(f),
             AstNodes::TSInferType(it) => it.needs_parentheses(f),
             AstNodes::TSConstructorType(it) => it.needs_parentheses(f),
+            AstNodes::TSUnionType(it) => it.needs_parentheses(f),
             _ => {
                 // TODO: incomplete
                 false
@@ -40,3 +41,9 @@ impl<'a> NeedsParentheses<'a> for AstNode<'a, TSConstructorType<'a>> {
         matches!(self.parent, AstNodes::TSUnionType(_))
     }
 }
+
+impl<'a> NeedsParentheses<'a> for AstNode<'a, TSUnionType<'a>> {
+    fn needs_parentheses(&self, f: &Formatter<'_, 'a>) -> bool {
+        matches!(self.parent, AstNodes::TSArrayType(_))
+    }
+}

crates/oxc_formatter/src/write/mod.rs

@@ -1199,13 +1199,18 @@ impl<'a> FormatWrite<'a> for AstNode<'a, TSConditionalType<'a>> {
 impl<'a> FormatWrite<'a> for AstNode<'a, TSUnionType<'a>> {
     fn write(&self, f: &mut Formatter<'_, 'a>) -> FormatResult<()> {
         let mut types = self.types().iter();
+        if self.needs_parentheses(f) {
+            write!(f, "(")?;
+        }
         if let Some(item) = types.next() {
             write!(f, item)?;
 
             for item in types {
                 write!(f, [" | ", item])?;
             }
-            return Ok(());
+        }
+        if self.needs_parentheses(f) {
+            write!(f, ")")?;
         }
         Ok(())
     }

tasks/coverage/snapshots/formatter_typescript.snap

@@ -2,7 +2,7 @@ commit: 261630d6
 
 formatter_typescript Summary:
 AST Parsed     : 8816/8816 (100.00%)
-Positive Passed: 8732/8816 (99.05%)
+Positive Passed: 8733/8816 (99.06%)
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/APISample_jsdoc.ts
 
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/aliasInstantiationExpressionGenericIntersectionNoCrash1.ts
@@ -163,8 +163,6 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/types/objectT
 
 Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/types/rest/genericObjectRest.ts
 
-Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/types/specifyingTypes/typeLiterals/parenthesizedTypes.ts
-
 Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/types/tuple/named/namedTupleMembers.ts
 
 Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/types/uniqueSymbol/uniqueSymbols.ts

tasks/prettier_conformance/snapshots/prettier.ts.snap.md

@@ -1,4 +1,4 @@
-ts compatibility: 349/573 (60.91%)
+ts compatibility: 350/573 (61.08%)
 
 # Failed
 
@@ -9,7 +9,7 @@ ts compatibility: 349/573 (60.91%)
 | jsx/jsx/quotes.js | 💥💥💥💥 | 79.41% |
 | jsx/single-attribute-per-line/single-attribute-per-line.js | 💥✨ | 43.37% |
 | jsx/text-wrap/test.js | 💥 | 99.56% |
-| typescript/ambient/ambient.ts | 💥 | 88.24% |
+| typescript/ambient/ambient.ts | 💥 | 94.12% |
 | typescript/angular-component-examples/15934-computed.component.ts | 💥💥 | 76.92% |
 | typescript/angular-component-examples/15934.component.ts | 💥💥 | 53.85% |
 | typescript/angular-component-examples/test.component.ts | 💥💥 | 41.18% |
@@ -219,9 +219,8 @@ ts compatibility: 349/573 (60.91%)
 | typescript/typeparams/trailing-comma/type-paramters.ts | 💥💥💥 | 28.57% |
 | typescript/union/comments.ts | 💥 | 15.38% |
 | typescript/union/inlining.ts | 💥 | 36.22% |
-| typescript/union/union-parens.ts | 💥 | 55.00% |
+| typescript/union/union-parens.ts | 💥 | 56.00% |
 | typescript/union/with-type-params.ts | 💥 | 0.00% |
-| typescript/union/consistent-with-flow/comment.ts | 💥 | 0.00% |
 | typescript/union/consistent-with-flow/prettier-ignore.ts | 💥 | 19.05% |
 | typescript/union/consistent-with-flow/single-type.ts | 💥 | 3.39% |
 | typescript/union/consistent-with-flow/within-tuple.ts | 💥 | 16.51% |