fix(semantic): allow reserved keywords in typescript ambient contexts

Author: sapphi-red

crates/oxc_semantic/src/checker/javascript.rs

@@ -99,8 +99,11 @@ pub const STRICT_MODE_NAMES: Set<&'static str> = phf_set! {
 };
 
 pub fn check_identifier(name: &str, span: Span, ctx: &SemanticBuilder<'_>) {
-    // ts module block allows revered keywords
-    if ctx.current_scope_flags().is_ts_module_block() {
+    // reserved keywords are allowed in ambient contexts
+    if ctx.source_type.is_typescript_definition()
+        || ctx.current_scope_flags().is_ts_module_block()
+        || is_current_node_ambient_binding(ctx)
+    {
         return;
     }
     if name == "await" {
@@ -120,6 +123,16 @@ pub fn check_identifier(name: &str, span: Span, ctx: &SemanticBuilder<'_>) {
     }
 }
 
+fn is_current_node_ambient_binding(ctx: &SemanticBuilder<'_>) -> bool {
+    if let AstKind::BindingIdentifier(id) = ctx.nodes.kind(ctx.current_node_id)
+        && let Some(symbol_id) = id.symbol_id.get()
+    {
+        ctx.scoping.symbol_flags(symbol_id).contains(SymbolFlags::Ambient)
+    } else {
+        false
+    }
+}
+
 fn unexpected_identifier_assign(x0: &str, span1: Span) -> OxcDiagnostic {
     OxcDiagnostic::error(format!("Cannot assign to '{x0}' in strict mode")).with_label(span1)
 }

tasks/coverage/misc/pass/declare-let-private.ts

@@ -0,0 +1,3 @@
+declare let private: number;
+
+export {};

tasks/coverage/snapshots/codegen_misc.snap

@@ -1,3 +1,3 @@
 codegen_misc Summary:
-AST Parsed     : 49/49 (100.00%)
-Positive Passed: 49/49 (100.00%)
+AST Parsed     : 50/50 (100.00%)
+Positive Passed: 50/50 (100.00%)

tasks/coverage/snapshots/formatter_misc.snap

@@ -1,3 +1,3 @@
 formatter_misc Summary:
-AST Parsed     : 49/49 (100.00%)
-Positive Passed: 49/49 (100.00%)
+AST Parsed     : 50/50 (100.00%)
+Positive Passed: 50/50 (100.00%)

tasks/coverage/snapshots/parser_misc.snap

@@ -1,6 +1,6 @@
 parser_misc Summary:
-AST Parsed     : 49/49 (100.00%)
-Positive Passed: 49/49 (100.00%)
+AST Parsed     : 50/50 (100.00%)
+Positive Passed: 50/50 (100.00%)
 Negative Passed: 108/108 (100.00%)
 
   × Cannot assign to 'arguments' in strict mode

tasks/coverage/snapshots/parser_typescript.snap

@@ -2,7 +2,7 @@ commit: 48244d89
 
 parser_typescript Summary:
 AST Parsed     : 9816/9817 (99.99%)
-Positive Passed: 9804/9817 (99.87%)
+Positive Passed: 9805/9817 (99.88%)
 Negative Passed: 1455/2545 (57.17%)
 Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/ExportAssignment7.ts
 
@@ -2365,23 +2365,6 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/es6/moduleExp
  65 │     var y = _;
     ╰────
 
-Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/externalModules/topLevelAwait.3.ts
-
-  × The keyword 'await' is reserved
-   ╭─[typescript/tests/cases/conformance/externalModules/topLevelAwait.3.ts:3:15]
- 2 │ export {};
- 3 │ declare const await: any;
-   ·               ──────────
- 4 │ declare class C extends await {}
-   ╰────
-
-  × The keyword 'await' is reserved
-   ╭─[typescript/tests/cases/conformance/externalModules/topLevelAwait.3.ts:4:25]
- 3 │ declare const await: any;
- 4 │ declare class C extends await {}
-   ·                         ─────
-   ╰────
-
 Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName11.ts
 
   × Function implementation is missing or not immediately following the declaration.

tasks/coverage/snapshots/semantic_misc.snap

@@ -1,6 +1,11 @@
 semantic_misc Summary:
-AST Parsed     : 49/49 (100.00%)
-Positive Passed: 31/49 (63.27%)
+AST Parsed     : 50/50 (100.00%)
+Positive Passed: 31/50 (62.00%)
+semantic Error: tasks/coverage/misc/pass/declare-let-private.ts
+Bindings mismatch:
+after transform: ScopeId(0): ["private"]
+rebuilt        : ScopeId(0): []
+
 semantic Error: tasks/coverage/misc/pass/oxc-11593.ts
 Scope children mismatch:
 after transform: ScopeId(0): [ScopeId(1)]

tasks/coverage/snapshots/semantic_typescript.snap

@@ -2,7 +2,7 @@ commit: 48244d89
 
 semantic_typescript Summary:
 AST Parsed     : 6146/6146 (100.00%)
-Positive Passed: 2660/6146 (43.28%)
+Positive Passed: 2661/6146 (43.30%)
 semantic Error: tasks/coverage/typescript/tests/cases/compiler/2dArrays.ts
 Symbol reference IDs mismatch for "Cell":
 after transform: SymbolId(0): [ReferenceId(1)]
@@ -42819,10 +42819,6 @@ Scope children mismatch:
 after transform: ScopeId(0): [ScopeId(1)]
 rebuilt        : ScopeId(0): []
 
-semantic Error: tasks/coverage/typescript/tests/cases/conformance/externalModules/topLevelAwait.3.ts
-The keyword 'await' is reserved
-The keyword 'await' is reserved
-
 semantic Error: tasks/coverage/typescript/tests/cases/conformance/externalModules/typeAndNamespaceExportMerge.ts
 Scope children mismatch:
 after transform: ScopeId(0): [ScopeId(1)]

tasks/coverage/snapshots/transformer_misc.snap

@@ -1,3 +1,3 @@
 transformer_misc Summary:
-AST Parsed     : 49/49 (100.00%)
-Positive Passed: 49/49 (100.00%)
+AST Parsed     : 50/50 (100.00%)
+Positive Passed: 50/50 (100.00%)