fix(formatter): non-nested static member expressions will never break

Dunqing · Dunqing · commit b7d655c89958 · 2025-10-24T10:30:24.000+08:00
diff --git a/crates/oxc_formatter/src/write/member_expression.rs b/crates/oxc_formatter/src/write/member_expression.rs
@@ -127,7 +127,8 @@ fn layout<'a>(
             if no_break || is_member_chain {
                 return StaticMemberLayout::NoBreak;
             }
-            true
+
+            false
         }
         AstNodes::StaticMemberExpression(_) | AstNodes::ComputedMemberExpression(_) => true,
         _ => false,
diff --git a/crates/oxc_formatter/tests/fixtures/js/assignments/static-member.js b/crates/oxc_formatter/tests/fixtures/js/assignments/static-member.js
@@ -0,0 +1 @@
+options = BracketMatchingControllerLONGLONGLONG._DECORATION_OPTIONS_WITHOUT_OVERVIEW_RULER;
diff --git a/crates/oxc_formatter/tests/fixtures/js/assignments/static-member.js.snap b/crates/oxc_formatter/tests/fixtures/js/assignments/static-member.js.snap
@@ -0,0 +1,10 @@
+---
+source: crates/oxc_formatter/tests/fixtures/mod.rs
+---
+==================== Input ====================
+options = BracketMatchingControllerLONGLONGLONG._DECORATION_OPTIONS_WITHOUT_OVERVIEW_RULER;
+==================== Output ====================
+options =
+  BracketMatchingControllerLONGLONGLONG._DECORATION_OPTIONS_WITHOUT_OVERVIEW_RULER;
+
+===================== End =====================

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,8 @@ fn layout<'a>(`
`127`	`127`	`if no_break \|\| is_member_chain {`
`128`	`128`	`return StaticMemberLayout::NoBreak;`
`129`	`129`	`}`
`130`		`- true`
	`130`	`+`
	`131`	`+ false`
`131`	`132`	`}`
`132`	`133`	`AstNodes::StaticMemberExpression(_) \| AstNodes::ComputedMemberExpression(_) => true,`
`133`	`134`	`_ => false,`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+options = BracketMatchingControllerLONGLONGLONG._DECORATION_OPTIONS_WITHOUT_OVERVIEW_RULER;`