Skip to content

Commit ba6517b

Browse files
ivovcamc314
andauthored
feat(linter): Add no-warning-comments rule (#14734)
This ports ESLint's [`no-warning-comments`](https://eslint.org/docs/latest/rules/no-warning-comments) rule to catch `TODO`, `FIXME`, etc. comments before production. --------- Co-authored-by: Cameron Clark <cameron.clark@hey.com>
1 parent 22ee19f commit ba6517b

File tree

4 files changed

+748
-0
lines changed

4 files changed

+748
-0
lines changed

crates/oxc_linter/src/generated/rule_runner_impls.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -873,6 +873,11 @@ impl RuleRunner for crate::rules::eslint::no_void::NoVoid {
873873
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
874874
}
875875

876+
impl RuleRunner for crate::rules::eslint::no_warning_comments::NoWarningComments {
877+
const NODE_TYPES: Option<&AstTypesBitset> = None;
878+
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::RunOnce;
879+
}
880+
876881
impl RuleRunner for crate::rules::eslint::no_with::NoWith {
877882
const NODE_TYPES: Option<&AstTypesBitset> =
878883
Some(&AstTypesBitset::from_types(&[AstType::WithStatement]));

crates/oxc_linter/src/rules.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ pub(crate) mod eslint {
171171
pub mod no_useless_rename;
172172
pub mod no_var;
173173
pub mod no_void;
174+
pub mod no_warning_comments;
174175
pub mod no_with;
175176
pub mod operator_assignment;
176177
pub mod prefer_destructuring;
@@ -792,6 +793,7 @@ oxc_macros::declare_all_lint_rules! {
792793
eslint::no_useless_rename,
793794
eslint::no_var,
794795
eslint::no_void,
796+
eslint::no_warning_comments,
795797
eslint::no_with,
796798
eslint::operator_assignment,
797799
eslint::prefer_template,

0 commit comments

Comments
 (0)