fix(linter/react-hooks): fix diagnostic message for literal in dependency array

Author: camc314

crates/oxc_linter/src/rules/react/exhaustive_deps.rs

@@ -119,6 +119,13 @@ fn dependency_array_not_array_literal_diagnostic(hook_name: &str, span: Span) ->
     .with_error_code_scope(SCOPE)
 }
 
+fn literal_in_dependency_array_diagnostic(span: Span) -> OxcDiagnostic {
+    OxcDiagnostic::warn("The literal is not a valid dependency because it never changes.")
+        .with_label(span)
+        .with_help("Remove the literal from the array.")
+        .with_error_code_scope(SCOPE)
+}
+
 fn duplicate_dependency_diagnostic(span: Span) -> OxcDiagnostic {
     OxcDiagnostic::warn("This dependency is specified more than once in the dependency array.")
         .with_label(span)
@@ -531,10 +538,14 @@ impl Rule for ExhaustiveDeps {
                     if let Ok(dep) = analyze_property_chain(elem, ctx) {
                         dep
                     } else {
-                        ctx.diagnostic(complex_expression_in_dependency_array_diagnostic(
-                            hook_name.as_str(),
-                            elem.span(),
-                        ));
+                        if elem.is_literal() {
+                            ctx.diagnostic(literal_in_dependency_array_diagnostic(elem.span()));
+                        } else {
+                            ctx.diagnostic(complex_expression_in_dependency_array_diagnostic(
+                                hook_name.as_str(),
+                                elem.span(),
+                            ));
+                        }
                         None
                     }
                 }