wip: skip rules that do not have any relevant node types

Author: camchenry

crates/oxc_linter/src/lib.rs

@@ -56,7 +56,7 @@ pub use crate::{
     module_record::ModuleRecord,
     options::LintOptions,
     options::{AllowWarnDeny, InvalidFilterKind, LintFilter, LintFilterKind},
-    rule::{RuleCategory, RuleFixMeta, RuleMeta},
+    rule::{RuleCategory, RuleFixMeta, RuleMeta, RuleRunner},
     service::{LintService, LintServiceOptions, RuntimeFileSystem},
     tsgolint::TsGoLintState,
     utils::{read_to_arena_str, read_to_string},

crates/oxc_linter/src/rule.rs

@@ -5,7 +5,7 @@ use std::{fmt, hash::Hash};
 use schemars::{JsonSchema, SchemaGenerator, schema::Schema};
 use serde::{Deserialize, Serialize};
 
-use oxc_semantic::SymbolId;
+use oxc_semantic::{AstTypesBitset, SymbolId};
 
 use crate::{
     AstNode, FixKind,
@@ -66,6 +66,16 @@ pub trait Rule: Sized + Default + fmt::Debug {
     }
 }
 
+pub trait RuleRunner: Rule {
+    /// `AstType`s that rule acts on
+    const NODE_TYPES: &AstTypesBitset;
+    /// `true` if codegen can't figure out what node types rule acts on
+    const ANY_NODE_TYPE: bool;
+
+    fn types_info(&self) -> (&'static AstTypesBitset, bool) {
+        (Self::NODE_TYPES, Self::ANY_NODE_TYPE)
+    }
+}
 pub trait RuleMeta {
     const NAME: &'static str;
 

crates/oxc_linter/src/tsgolint.rs

@@ -77,6 +77,7 @@ impl TsGoLintState {
                     return Err(format!("Failed to write to tsgolint stdin: {e}"));
                 }
             }
+            dbg!(&json_input);
             // Explicitly drop stdin to send EOF to the child.
             drop(stdin);
 

crates/oxc_macros/src/declare_all_lint_rules.rs

@@ -82,7 +82,7 @@ pub fn declare_all_lint_rules(metadata: AllLintRulesMeta) -> TokenStream {
             utils::PossibleJestNode,
             AstNode
         };
-        use oxc_semantic::SymbolId;
+        use oxc_semantic::{AstTypesBitset, SymbolId};
 
         #[derive(Debug, Clone)]
         #[expect(clippy::enum_variant_names)]
@@ -183,6 +183,12 @@ pub fn declare_all_lint_rules(metadata: AllLintRulesMeta) -> TokenStream {
                     #(Self::#struct_names(rule) => #struct_names::IS_TSGOLINT_RULE),*
                 }
             }
+
+            fn types_info(&self) -> (&'static AstTypesBitset, bool) {
+                match self {
+                    #(Self::#struct_names(rule) => #struct_names.types_info()),*
+                }
+            }
         }
 
         impl std::hash::Hash for RuleEnum {

crates/oxc_macros/src/declare_oxc_lint.rs

@@ -173,7 +173,10 @@ pub fn declare_oxc_lint(metadata: LintRuleMeta) -> TokenStream {
     let import_statement = if used_in_test {
         None
     } else {
-        Some(quote! { use crate::{rule::{RuleCategory, RuleMeta, RuleFixMeta}, fixer::FixKind}; })
+        Some(quote! {
+            use crate::{rule::{RuleCategory, RuleMeta, RuleFixMeta, RuleRunner}, fixer::FixKind};
+            use oxc_semantic::AstTypesBitset;
+        })
     };
 
     #[cfg(not(feature = "ruledocs"))]
@@ -223,6 +226,16 @@ pub fn declare_oxc_lint(metadata: LintRuleMeta) -> TokenStream {
 
             #config_schema
         }
+
+        impl RuleRunner for #name {
+            const NODE_TYPES: &'static AstTypesBitset = &AstTypesBitset::new();
+
+            const ANY_NODE_TYPE: bool = true;
+
+            fn types_info(&self) -> (&'static AstTypesBitset, bool) {
+                (Self::NODE_TYPES, Self::ANY_NODE_TYPE)
+            }
+        }
     };
 
     TokenStream::from(output)

crates/oxc_semantic/src/ast_types_bitset.rs

@@ -16,6 +16,16 @@ impl AstTypesBitset {
         Self([0; NUM_USIZES])
     }
 
+    pub const fn from_types(types: &[AstType]) -> Self {
+        let mut bitset = Self::new();
+        let mut i = 0;
+        while i < types.len() {
+            bitset.set(types[i]);
+            i += 1;
+        }
+        bitset
+    }
+
     /// Returns `true` if bit is set for provided [`AstType`].
     pub const fn has(&self, ty: AstType) -> bool {
         let (index, mask) = Self::index_and_mask(ty);

crates/oxc_semantic/src/lib.rs

@@ -36,6 +36,7 @@ mod scoping;
 mod stats;
 mod unresolved_stack;
 
+pub use ast_types_bitset::AstTypesBitset;
 pub use builder::{SemanticBuilder, SemanticBuilderReturn};
 pub use is_global_reference::IsGlobalReference;
 pub use jsdoc::{JSDoc, JSDocFinder, JSDocTag};

vscode

@@ -0,0 +1 @@
+../vscode