fix(linter): report errors with the correct severity for custom plugins

Author: camc314

crates/oxc_linter/src/lib.rs

@@ -278,9 +278,18 @@ impl Linter {
                                 // TODO: `error` isn't right, we need to get the severity from `external_rules`
                                 OxcDiagnostic::error(diagnostic.message)
                                     .with_label(Span::new(diagnostic.loc.start, diagnostic.loc.end))
-                                    .with_error_code(
-                                        plugin_name.to_string(),
-                                        rule_name.to_string(),
+                                    .with_error_code(plugin_name.to_string(), rule_name.to_string())
+                                    .with_severity(
+                                        (*external_rules
+                                            .iter()
+                                            .find(|(rule_id, _)| {
+                                                rule_id.raw() == diagnostic.external_rule_id
+                                            })
+                                            .map(|(_, severity)| severity)
+                                            .expect(
+                                                "external rule must exist when resolving severity",
+                                            ))
+                                        .into(),
                                     ),
                                 PossibleFixes::None,
                             ));

napi/oxlint2/test/__snapshots__/e2e.test.ts.snap

@@ -336,3 +336,22 @@ exports[`oxlint2 CLI > should report an error if a rule is not found within a cu
   x Rule 'unknown-rule' not found in plugin 'basic-custom-plugin'
 "
 `;
+
+exports[`oxlint2 CLI > should report the correct severity when using a custom plugin 1`] = `
+"
+  ! ]8;;https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-debugger.html\\eslint(no-debugger)]8;;\\: \`debugger\` statement is not allowed
+   ,-[index.js:1:1]
+ 1 | debugger;
+   : ^^^^^^^^^
+   \`----
+  help: Remove the debugger statement
+
+  ! basic-custom-plugin(no-debugger): Unexpected Debugger Statement
+   ,-[index.js:1:1]
+ 1 | debugger;
+   : ^^^^^^^^^
+   \`----
+
+Found 2 warnings and 0 errors.
+Finished in Xms on 1 file using X threads."
+`;

napi/oxlint2/test/e2e.test.ts

@@ -83,4 +83,13 @@ describe('oxlint2 CLI', () => {
     expect(exitCode).toBe(1);
     expect(normalizeOutput(stdout)).toMatchSnapshot();
   });
+
+  it('should report the correct severity when using a custom plugin', async () => {
+    const { stdout, exitCode } = await runOxlint(
+      'test/fixtures/basic_custom_plugin_warn_severity',
+    );
+
+    expect(exitCode).toBe(0);
+    expect(normalizeOutput(stdout)).toMatchSnapshot();
+  });
 });

napi/oxlint2/test/fixtures/basic_custom_plugin_warn_severity/.oxlintrc.json

@@ -0,0 +1,7 @@
+{
+    "plugins": ["./test_plugin"],
+    "rules": {
+        "basic-custom-plugin/no-debugger": "warn"
+    },
+    "ignorePatterns": ["test_plugin"]
+}

napi/oxlint2/test/fixtures/basic_custom_plugin_warn_severity/index.js

@@ -0,0 +1 @@
+debugger;

napi/oxlint2/test/fixtures/basic_custom_plugin_warn_severity/test_plugin/index.js

@@ -0,0 +1,19 @@
+export default {
+  meta: {
+    name: "basic-custom-plugin",
+  },
+  rules: {
+    "no-debugger": {
+      create(context) {
+        return {
+          DebuggerStatement(debuggerStatement) {
+            context.report({
+              message: "Unexpected Debugger Statement",
+              node: debuggerStatement,
+            });
+          },
+        };
+      },
+    },
+  },
+};