fix(formatter): incorrect formatting of a function with this parameter (#15031)

Author: Dunqing

crates/oxc_formatter/src/write/parameters.rs

@@ -110,11 +110,10 @@ impl<'a> FormatWrite<'a> for AstNode<'a, FormalParameter<'a>> {
         });
 
         let is_hug_parameter = matches!(self.parent, AstNodes::FormalParameters(params) if {
-            let this_param = get_this_param(self.parent);
-            let parentheses_not_needed = if let AstNodes::ArrowFunctionExpression(arrow) = params.parent {
-                can_avoid_parentheses(arrow, f)
+            let (parentheses_not_needed, this_param) = if let AstNodes::ArrowFunctionExpression(arrow) = params.parent {
+                (can_avoid_parentheses(arrow, f), None)
             } else {
-                false
+                (false, get_this_param(params.parent))
             };
             should_hug_function_parameters(params, this_param, parentheses_not_needed, f)
         });

crates/oxc_formatter/tests/fixtures/ts/functions/this.ts

@@ -0,0 +1,5 @@
+function paragraph(
+  this: marked.Renderer,
+  { tokens }: marked.Tokens.Paragraph
+): string {
+}

crates/oxc_formatter/tests/fixtures/ts/functions/this.ts.snap

@@ -0,0 +1,17 @@
+---
+source: crates/oxc_formatter/tests/fixtures/mod.rs
+---
+==================== Input ====================
+function paragraph(
+  this: marked.Renderer,
+  { tokens }: marked.Tokens.Paragraph
+): string {
+}
+
+==================== Output ====================
+function paragraph(
+  this: marked.Renderer,
+  { tokens }: marked.Tokens.Paragraph,
+): string {}
+
+===================== End =====================