fix(semantic): handle hoisting variable binding incorrectly

Author: Dunqing

crates/oxc_semantic/src/binder.rs

@@ -71,11 +71,6 @@ impl<'a> Binder<'a> for VariableDeclarator<'a> {
                         builder.add_redeclare_variable(symbol_id, includes, span);
                         declared_symbol_id = Some(symbol_id);
 
-                        // remove current scope binding and add to target scope
-                        // avoid same symbols appear in multi-scopes
-                        builder.scoping.remove_binding(scope_id, &name);
-                        builder.scoping.add_binding(target_scope_id, &name, symbol_id);
-                        builder.scoping.symbol_scope_ids[symbol_id] = target_scope_id;
                         break;
                     }
                 }

crates/oxc_semantic/tests/fixtures/oxc/js/try-catch/with-same-name-var.js

@@ -0,0 +1,7 @@
+var a = 1;
+try {
+  throw 2
+} catch (a) {
+  var a = 3;
+}
+console.log(a);

crates/oxc_semantic/tests/fixtures/oxc/js/try-catch/with-same-name-var.snap

@@ -0,0 +1,59 @@
+---
+source: crates/oxc_semantic/tests/main.rs
+input_file: crates/oxc_semantic/tests/fixtures/oxc/js/try-catch/with-same-name-var.js
+---
+[
+  {
+    "children": [
+      {
+        "children": [],
+        "flags": "ScopeFlags(StrictMode)",
+        "id": 1,
+        "node": "BlockStatement",
+        "symbols": []
+      },
+      {
+        "children": [
+          {
+            "children": [],
+            "flags": "ScopeFlags(StrictMode)",
+            "id": 3,
+            "node": "BlockStatement",
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable | CatchVariable)",
+                "id": 1,
+                "name": "a",
+                "node": "CatchParameter",
+                "references": []
+              }
+            ]
+          }
+        ],
+        "flags": "ScopeFlags(StrictMode | CatchClause)",
+        "id": 2,
+        "node": "CatchClause",
+        "symbols": []
+      }
+    ],
+    "flags": "ScopeFlags(StrictMode | Top)",
+    "id": 0,
+    "node": "Program",
+    "symbols": [
+      {
+        "flags": "SymbolFlags(FunctionScopedVariable)",
+        "id": 0,
+        "name": "a",
+        "node": "VariableDeclarator(a)",
+        "references": [
+          {
+            "flags": "ReferenceFlags(Read)",
+            "id": 1,
+            "name": "a",
+            "node_id": 23
+          }
+        ]
+      }
+    ]
+  }
+]