Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: add support "ignores" to config #7032

Closed
Tracked by #4146
pumano opened this issue Oct 30, 2024 · 2 comments · Fixed by #7092
Closed
Tracked by #4146

linter: add support "ignores" to config #7032

pumano opened this issue Oct 30, 2024 · 2 comments · Fixed by #7092
Labels
A-linter Area - Linter C-bug Category - Bug E-Help Wanted Experience level - For the experienced collaborators

Comments

@pumano
Copy link
Contributor

pumano commented Oct 30, 2024

What version of Oxlint are you using?

0.10.3

What command did you run?

No response

What does your .oxlint.json config file look like?

proposed example:

{
  "$schema": "./node_modules/oxlint/configuration_schema.json",
  "ignores": [
      "packages/*",
      ".nx/",
      "dist/"
  ],
  "plugins": ["import", "unicorn"],
  "rules": {
    "oxc/no-barrel-file": "warn"
  }

What happened?

When I use eslint flat config with eslint 9, eslint spam me warning about not use .eslintignore which is only way to ignore files and folders supported by oxlint.

I suggest to support "ignores" in config from eslint flat config which way to set paths for ignoring. Link to ignores in eslint website: https://eslint.org/docs/latest/use/configure/ignore

After it implemented people from eslint 9 can use oxlint without annoying warnings.

@pumano pumano added A-linter Area - Linter C-bug Category - Bug labels Oct 30, 2024
@Boshen Boshen added the E-Help Wanted Experience level - For the experienced collaborators label Oct 31, 2024
@DonIsaac
Copy link
Contributor

DonIsaac commented Nov 4, 2024

Is an .eslintignore not sufficient?

@pumano
Copy link
Contributor Author

pumano commented Nov 5, 2024

Is an .eslintignore not sufficient?

It's deprecated in eslint 9, and it's warn every time I run eslint, also I use nx, which all jobs internally rely on eslint and warn every job run (build, test, lint, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug E-Help Wanted Experience level - For the experienced collaborators
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants