Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazily read package.json.exports for shared resolvers #137

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Apr 23, 2024

relates #135

This PR removes all encapsulations around imports / exports map so we can dynamically retrieve and evaluate their values :-(

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 98.46154% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.08%. Comparing base (b2e2094) to head (be4b89d).

Files Patch % Lines
src/lib.rs 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   95.01%   95.08%   +0.07%     
==========================================
  Files          11       11              
  Lines        2246     2238       -8     
==========================================
- Hits         2134     2128       -6     
+ Misses        112      110       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 23, 2024

CodSpeed Performance Report

Merging #137 will not alter performance

Comparing exports (be4b89d) with main (b2e2094)

Summary

✅ 2 untouched benchmarks

@Boshen Boshen merged commit 675f5e3 into main Apr 23, 2024
21 checks passed
@Boshen Boshen deleted the exports branch April 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant