Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the browser field lookup in resolve_esm_match #141

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Apr 23, 2024

No description provided.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (c971213) to head (669aa5f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   95.08%   95.07%   -0.01%     
==========================================
  Files          11       11              
  Lines        2257     2253       -4     
==========================================
- Hits         2146     2142       -4     
  Misses        111      111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 23, 2024

CodSpeed Performance Report

Merging #141 will not alter performance

Comparing browser-field (669aa5f) with main (c971213)

Summary

✅ 2 untouched benchmarks

@Boshen Boshen changed the title chore: try removing browser field lookup in resolve_esm_match refactor: remove the browser field lookup in resolve_esm_match Apr 23, 2024
@Boshen Boshen merged commit 1dc1eec into main Apr 23, 2024
21 checks passed
@Boshen Boshen deleted the browser-field branch April 23, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant