Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazily read package.json.browser_fields for shared resolvers #142

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Apr 23, 2024

No description provided.

Copy link

codspeed-hq bot commented Apr 23, 2024

CodSpeed Performance Report

Merging #142 will degrade performances by 29.15%

Comparing browser-field-refactor2 (35b482f) with main (b887e55)

Summary

❌ 2 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main browser-field-refactor2 Change
resolver[multi-thread] 2 ms 2.8 ms -26.48%
resolver[single-thread] 1.8 ms 2.5 ms -29.15%

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (b887e55) to head (35b482f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   96.03%   96.08%   +0.05%     
==========================================
  Files          11       11              
  Lines        2272     2276       +4     
==========================================
+ Hits         2182     2187       +5     
+ Misses         90       89       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen force-pushed the browser-field-refactor2 branch from a5f54c0 to 1cdc88e Compare April 23, 2024 16:40
@Boshen Boshen force-pushed the browser-field-refactor2 branch from 1cdc88e to 35b482f Compare April 23, 2024 16:41
@Boshen Boshen merged commit d345d3d into main Apr 23, 2024
20 of 21 checks passed
@Boshen Boshen deleted the browser-field-refactor2 branch April 23, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant