Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RootsPlugin should fall through if it fails to resolve the roots #144

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Apr 24, 2024

Prefix for web-infra-dev/rspack#6340

In enhanced-resolve, when resolving with roots failed, will continue resolve it instead of returning error

Copy link

codspeed-hq bot commented Apr 24, 2024

CodSpeed Performance Report

Merging #144 will not alter performance

Comparing ahabhgk:fix-roots-fall-through (9be1bad) with main (d345d3d)

Summary

✅ 2 untouched benchmarks

@Boshen Boshen self-requested a review April 24, 2024 06:14
@Boshen Boshen changed the title fix: roots fall through fix: RootsPlugin should fall through if it fails to resolve Apr 24, 2024
@Boshen Boshen changed the title fix: RootsPlugin should fall through if it fails to resolve fix: RootsPlugin should fall through if it fails to resolve the roots Apr 24, 2024
@Boshen Boshen merged commit 87dc7f0 into oxc-project:main Apr 24, 2024
18 checks passed
@ahabhgk ahabhgk deleted the fix-roots-fall-through branch April 24, 2024 06:34
@ahabhgk ahabhgk restored the fix-roots-fall-through branch April 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants