Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use simdutf8 to validate UTF-8 when reading files #237

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Aug 26, 2024

No description provided.

Copy link

codspeed-hq bot commented Aug 26, 2024

CodSpeed Performance Report

Merging #237 will not alter performance

Comparing simd (4cad9e6) with main (6c4297b)

Summary

✅ 3 untouched benchmarks

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.88%. Comparing base (6c4297b) to head (4cad9e6).
Report is 1 commits behind head on main.

Files Patch % Lines
src/file_system.rs 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   97.04%   96.88%   -0.16%     
==========================================
  Files          11       11              
  Lines        2366     2377      +11     
==========================================
+ Hits         2296     2303       +7     
- Misses         70       74       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen merged commit 587bdab into main Aug 26, 2024
21 checks passed
@Boshen Boshen deleted the simd branch August 26, 2024 05:14
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Aug 26, 2024
This updates the remaining utf8 checking code
oxc-project/oxc-resolver#237


Before:

<img width="1506" alt="image"
src="https://github.com/user-attachments/assets/443c7f0e-d0da-40b8-8a45-19dc1d0dc3e7">

After:

(`read_to_string` is gone, the cumulated time is a bit faster on a M2)

<img width="1389" alt="image"
src="https://github.com/user-attachments/assets/af86d463-911a-4532-acfd-3832f3bc5cfc">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant