Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show tried extension aliases in ResolveError::ExtensionAlias #251

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 25, 2024

It is now displayed as Cannot resolve 'index.mjs' with extension aliases 'index.mts' in ...

Copy link
Member Author

Boshen commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #251 will not alter performance

Comparing 09-25-feat_show_tried_extension_aliases_in_resolveerror_extensionalias_ (468a823) with main (88caae4)

Summary

✅ 3 untouched benchmarks

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.99%. Comparing base (88caae4) to head (468a823).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   96.98%   96.99%   +0.01%     
==========================================
  Files          11       11              
  Lines        2355     2364       +9     
==========================================
+ Hits         2284     2293       +9     
  Misses         71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It is now displayed as `Cannot resolve 'index.mjs' with extension aliases 'index.mts' in ...`
@Boshen Boshen force-pushed the 09-25-feat_show_tried_extension_aliases_in_resolveerror_extensionalias_ branch from eea58f6 to 468a823 Compare September 25, 2024 07:04
@Boshen Boshen merged commit 52f3a25 into main Sep 25, 2024
8 checks passed
Copy link
Member Author

Boshen commented Sep 25, 2024

Merge activity

@Boshen Boshen deleted the 09-25-feat_show_tried_extension_aliases_in_resolveerror_extensionalias_ branch September 25, 2024 07:04
This was referenced Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant