Skip to content

Commit 2f8a2e7

Browse files
committed
perf: no-array-delete: only get token ranges when fixing
1 parent fe274cb commit 2f8a2e7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

internal/rules/no_array_delete/no_array_delete.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,14 @@ var NoArrayDeleteRule = rule.Rule{
6565
return
6666
}
6767

68-
expressionRange := utils.TrimNodeTextRange(ctx.SourceFile, expression.Expression)
69-
argumentRange := utils.TrimNodeTextRange(ctx.SourceFile, expression.ArgumentExpression)
68+
ctx.ReportNodeWithSuggestions(node, buildNoArrayDeleteMessage(), func() []rule.RuleSuggestion {
69+
expressionRange := utils.TrimNodeTextRange(ctx.SourceFile, expression.Expression)
70+
argumentRange := utils.TrimNodeTextRange(ctx.SourceFile, expression.ArgumentExpression)
7071

71-
deleteTokenRange := scanner.GetRangeOfTokenAtPosition(ctx.SourceFile, node.Pos())
72-
leftBracketTokenRange := scanner.GetRangeOfTokenAtPosition(ctx.SourceFile, expressionRange.End())
73-
rightBracketTokenRange := scanner.GetRangeOfTokenAtPosition(ctx.SourceFile, argumentRange.End())
72+
deleteTokenRange := scanner.GetRangeOfTokenAtPosition(ctx.SourceFile, node.Pos())
73+
leftBracketTokenRange := scanner.GetRangeOfTokenAtPosition(ctx.SourceFile, expressionRange.End())
74+
rightBracketTokenRange := scanner.GetRangeOfTokenAtPosition(ctx.SourceFile, argumentRange.End())
7475

75-
ctx.ReportNodeWithSuggestions(node, buildNoArrayDeleteMessage(), func() []rule.RuleSuggestion {
7676
return []rule.RuleSuggestion{{
7777
Message: buildUseSpliceMessage(),
7878
FixesArr: []rule.RuleFix{

0 commit comments

Comments
 (0)