perf: no-unnecessary-boolean-literal-compare: only build fixes when needed

Author: camchenry

internal/rules/no_unnecessary_boolean_literal_compare/no_unnecessary_boolean_literal_compare.go

@@ -175,36 +175,37 @@ var NoUnnecessaryBooleanLiteralCompareRule = rule.Rule{
 					msg = buildDirectMessage()
 				}
 
-				parent := node.Parent
-				for ast.IsParenthesizedExpression(parent) {
-					parent = parent.Parent
-				}
-				isUnaryNegation := ast.IsPrefixUnaryExpression(parent) && parent.AsPrefixUnaryExpression().Operator == ast.KindExclamationToken
+				ctx.ReportNodeWithFixes(node, msg, func() []rule.RuleFix {
+					parent := node.Parent
+					for ast.IsParenthesizedExpression(parent) {
+						parent = parent.Parent
+					}
+					isUnaryNegation := ast.IsPrefixUnaryExpression(parent) && parent.AsPrefixUnaryExpression().Operator == ast.KindExclamationToken
 
-				shouldNegate := comparison.negated != comparison.literalBooleanInComparison
+					shouldNegate := comparison.negated != comparison.literalBooleanInComparison
 
-				mutatedNode := node
-				if isUnaryNegation {
-					mutatedNode = parent
-				}
+					mutatedNode := node
+					if isUnaryNegation {
+						mutatedNode = parent
+					}
 
-				fixes := make([]rule.RuleFix, 0, 6)
+					fixes := make([]rule.RuleFix, 0, 6)
 
-				fixes = append(fixes, rule.RuleFixReplace(ctx.SourceFile, mutatedNode, ctx.SourceFile.Text()[comparison.expression.Pos():comparison.expression.End()]))
+					fixes = append(fixes, rule.RuleFixReplace(ctx.SourceFile, mutatedNode, ctx.SourceFile.Text()[comparison.expression.Pos():comparison.expression.End()]))
 
-				if shouldNegate == isUnaryNegation {
-					fixes = append(fixes, rule.RuleFixInsertBefore(ctx.SourceFile, mutatedNode, "!"))
+					if shouldNegate == isUnaryNegation {
+						fixes = append(fixes, rule.RuleFixInsertBefore(ctx.SourceFile, mutatedNode, "!"))
 
-					if !utils.IsStrongPrecedenceNode(comparison.expression) {
-						fixes = append(fixes, rule.RuleFixInsertBefore(ctx.SourceFile, mutatedNode, "("), rule.RuleFixInsertAfter(mutatedNode, ")"))
+						if !utils.IsStrongPrecedenceNode(comparison.expression) {
+							fixes = append(fixes, rule.RuleFixInsertBefore(ctx.SourceFile, mutatedNode, "("), rule.RuleFixInsertAfter(mutatedNode, ")"))
+						}
 					}
-				}
-
-				if comparison.expressionIsNullableBoolean && !comparison.literalBooleanInComparison {
-					fixes = append(fixes, rule.RuleFixInsertBefore(ctx.SourceFile, mutatedNode, "("), rule.RuleFixInsertAfter(mutatedNode, " ?? true)"))
-				}
 
-				ctx.ReportNodeWithFixes(node, msg, func() []rule.RuleFix { return fixes })
+					if comparison.expressionIsNullableBoolean && !comparison.literalBooleanInComparison {
+						fixes = append(fixes, rule.RuleFixInsertBefore(ctx.SourceFile, mutatedNode, "("), rule.RuleFixInsertAfter(mutatedNode, " ?? true)"))
+					}
+					return fixes
+				})
 			},
 		}
 	},