-
Notifications
You must be signed in to change notification settings - Fork 15
Merlin downstreams for renaming voodoos #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e1f10a1 to
0209b80
Compare
|
Thanks for the fixes @liam923 the diff also looks ok to me. |
…both the interface and the implementation (ocaml/merlin #1857)
Immediately grow the final index instead of building and merging.
0209b80 to
740f5f5
Compare
|
@voodoos and I have collectively reviewed up to 740f5f5. The most recent 7 commits are changes I made while reviewing and should get a second set of eyes. Here's a commit-by-commit commentary on those 7 commits:
I've also verified that this version of Merlin has expected test output in our internal codebase. |
|
I'm not sure why CI is failing - tests are succeeding for me locally. I'll look into it. |
Turns out a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the last 7 commits and am happy with them.
This is a duplicate of #152 that I made to get CI to run.