Skip to content

Commit 4792105

Browse files
authored
Try macos-14 runner for playwright tests (#1943)
* try macos-14 runner for playwright tests * bust npm cache * missed a node-version
1 parent a26db9e commit 4792105

File tree

3 files changed

+21
-27
lines changed

3 files changed

+21
-27
lines changed

.github/workflows/lintBuildTest.yml

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ on:
88
jobs:
99
install:
1010
timeout-minutes: 60
11-
runs-on: ubuntu-latest
11+
runs-on: macos-14
1212
steps:
13-
- uses: actions/checkout@v3
14-
- uses: actions/setup-node@v3
13+
- uses: actions/checkout@v4
14+
- uses: actions/setup-node@v4
1515
with:
16-
node-version: 18
16+
node-version: 20
1717
cache: 'npm'
1818
- name: Cache node_modules
1919
uses: actions/cache@v3
@@ -26,16 +26,13 @@ jobs:
2626
run: npm install
2727
ci:
2828
timeout-minutes: 5
29-
runs-on: ubuntu-latest
29+
runs-on: macos-14
3030
needs: install
3131
steps:
32-
# This repo is unstable and unnecessary: https://github.com/microsoft/linux-package-repositories/issues/34
33-
- name: Disable packages.microsoft.com repo
34-
run: sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
35-
- uses: actions/checkout@v3
36-
- uses: actions/setup-node@v3
32+
- uses: actions/checkout@v4
33+
- uses: actions/setup-node@v4
3734
with:
38-
node-version: 18
35+
node-version: 20
3936
cache: 'npm'
4037
- name: Get node_modules from cache
4138
uses: actions/cache@v3
@@ -54,20 +51,17 @@ jobs:
5451
playwright:
5552
name: Playwright (${{ matrix.browser }})
5653
timeout-minutes: 20
57-
runs-on: ubuntu-latest
54+
runs-on: macos-14
5855
needs: install
5956
strategy:
6057
fail-fast: false
6158
matrix:
6259
browser: ['chrome', 'firefox', 'safari']
6360
steps:
64-
# This repo is unstable and unnecessary: https://github.com/microsoft/linux-package-repositories/issues/34
65-
- name: Disable packages.microsoft.com repo
66-
run: sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
67-
- uses: actions/checkout@v3
68-
- uses: actions/setup-node@v3
61+
- uses: actions/checkout@v4
62+
- uses: actions/setup-node@v4
6963
with:
70-
node-version: 18
64+
node-version: 20
7165
cache: 'npm'
7266
- name: Get node_modules from cache
7367
uses: actions/cache@v3

package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"xterm-addon-attach": "^0.9.0",
7373
"xterm-addon-fit": "^0.8.0",
7474
"zod": "^3.22.4",
75-
"zustand": "^4.4.7"
75+
"zustand": "^4.5.0"
7676
},
7777
"devDependencies": {
7878
"@ianvs/prettier-plugin-sort-imports": "^4.1.1",

0 commit comments

Comments
 (0)