Skip to content

Commit 63c604b

Browse files
authored
minor: tweak image upload cancel e2e for less flake (#2440)
tweak image upload cancel e2e for less flake
1 parent b4e2626 commit 63c604b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/e2e/image-upload.e2e.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,18 +119,19 @@ test.describe('Image upload', () => {
119119

120120
await page.click('role=button[name="Upload image"]')
121121

122+
const progressModal = page.getByRole('dialog', { name: 'Image upload progress' })
123+
await expect(progressModal).toBeVisible()
124+
122125
// wait to be in the middle of upload
123126
const uploadStep = page
124-
.locator('div[data-status]')
127+
.getByTestId('upload-step')
125128
.filter({ hasText: 'Upload image file' })
126129
.first()
127130
await expect(uploadStep).toHaveAttribute('data-status', 'running')
128131

129132
// form is disabled and semi-hidden
130133
// await expectNotVisible(page, ['role=textbox[name="Name"]'])
131134

132-
const progressModal = page.getByRole('dialog', { name: 'Image upload progress' })
133-
134135
page.on('dialog', (dialog) => dialog.accept()) // click yes on the are you sure prompt
135136
await progressModal.getByRole('button', { name: 'Cancel' }).click()
136137

0 commit comments

Comments
 (0)