Skip to content

Commit 9e82f9a

Browse files
Fix issue where empty IP on a NIC is submitted as an empty string (#1811)
* Fix issue where empty IP on a NIC is submitted as an empty string * regen client with another oxide.ts fix --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
1 parent 5e11fd8 commit 9e82f9a

File tree

4 files changed

+41
-32
lines changed

4 files changed

+41
-32
lines changed

app/forms/network-interface-create.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import { useForm, useProjectSelector } from 'app/hooks'
2323
const defaultValues: InstanceNetworkInterfaceCreate = {
2424
name: '',
2525
description: '',
26-
ip: '',
26+
ip: undefined,
2727
subnetName: '',
2828
vpcName: '',
2929
}

libs/api/__generated__/msw-handlers.ts

Lines changed: 16 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libs/api/__generated__/validate.ts

Lines changed: 23 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tools/generate_api_client.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ GEN_DIR="$PWD/libs/api/__generated__"
1818

1919
# this will be less horrific when the package is published? or maybe not
2020
npm run --silent --prefix ../oxide.ts gen-from $OMICRON_SHA $GEN_DIR
21-
npx prettier --write --loglevel error "$GEN_DIR"
21+
npx prettier --write --log-level error "$GEN_DIR"
2222

2323
# hack until we start pulling this from npm. we don't want this file
2424
rm "$GEN_DIR/type-test.ts"

0 commit comments

Comments
 (0)