Disk details side modal (#2992)

* clean up AGENTS.md

* disk details side modal

* use ButtonCell for disk name on instance storage tab

* make disk name a link on snapshots table

* fix test flake due to clicking a disk link accidentally

* add footer with close button so ben can sleep

* make image edit and idp edit work the same way

* add ReadOnlySideModalForm, use it for the others

* open disk detail right on snapshots page, don't nav

* put back my smart quote

Author: david-crespo

AGENTS.md

@@ -17,8 +17,7 @@
 # API utilities & constants
 
 - Treat `app/api/util.ts` (and friends) as a thin translation layer: mirror backend rules only when the UI needs them, keep the client copy minimal, and always link to the authoritative Omicron source so reviewers can verify the behavior.
-- API constants live in `app/api/util.ts:25-38` with links to Omicron source: `MAX_NICS_PER_INSTANCE` (8), `INSTANCE_MAX_CPU` (64), `INSTANCE_MAX_RAM_GiB` (1536), `MIN_DISK_SIZE_GiB` (1), `MAX_DISK_SIZE_GiB` (1023), etc.
-- Use `ALL_ISH` (1000) from `app/util/consts.ts` when UI needs "approximately everything" for non-paginated queries—convention is to use this constant rather than magic numbers.
+- API constants live in `app/api/util.ts` with links to Omicron source.
 
 # Testing code
 
@@ -31,10 +30,10 @@
 
 # Data fetching pattern
 
-- Define endpoints with `apiq`, prefetch them in a `clientLoader`, then read data with `usePrefetchedQuery`.
-- Use `ALL_ISH` when the UI needs every item (e.g. release lists) and rely on `queryClient.invalidateEndpoint`—it now returns the `invalidateQueries` promise so it can be awaited (see `app/pages/system/UpdatePage.tsx`).
+- Define queries with `q(api.endpoint, params)` for single items or `getListQFn(api.listEndpoint, params)` for lists. Prefetch in `clientLoader` and read with `usePrefetchedQuery`; for on-demand fetches (modals, secondary data), use `useQuery` directly.
+- Use `ALL_ISH` from `app/util/consts.ts` when UI needs "all" items. Use `queryClient.invalidateEndpoint` to invalidate queries.
 - For paginated tables, compose `getListQFn` with `useQueryTable`; the helper wraps `limit`/`pageToken` handling and keeps placeholder data stable (`app/api/hooks.ts:123-188`, `app/pages/ProjectsPage.tsx:40-132`).
-- When a loader needs dependent data, fetch the primary list with `queryClient.fetchQuery`, prefetch its per-item queries, and only await a bounded batch so render isn’t blocked (see `app/pages/project/affinity/AffinityPage.tsx`).
+- When a loader needs dependent data, fetch the primary list with `queryClient.fetchQuery`, prefetch its per-item queries, and only await a bounded batch so render isn't blocked (see `app/pages/project/affinity/AffinityPage.tsx`).
 
 # Mutations & UI flow
 
@@ -83,15 +82,14 @@
 # Layout & accessibility
 
 - Build pages inside the shared `PageContainer`/`ContentPane` so you inherit the skip link, sticky footer, pagination target, and scroll restoration tied to `#scroll-container` (`app/layouts/helpers.tsx`, `app/hooks/use-scroll-restoration.ts`).
-- Surface page-level buttons and pagination via the `PageActions` and `Pagination` tunnels from `tunnel-rat`; anything rendered through `.In` components lands in the footer `.Target` automatically (`app/components/PageActions.tsx`, `app/components/Pagination.tsx`). This tunnel pattern is preferred over React portals for maintaining component co-location.
+- Surface page-level buttons and pagination via the `PageActions` and `Pagination` tunnels from `tunnel-rat`; anything rendered through `.In` lands in `.Target` automatically.
 - For global loading states, reuse `PageSkeleton`—it keeps the MSW banner and grid layout stable, and `skipPaths` lets you opt-out for routes with custom layouts (`app/components/PageSkeleton.tsx`).
 - Enforce accessibility at the type level: use `AriaLabel` type from `app/ui/util/aria.ts` which requires exactly one of `aria-label` or `aria-labelledby` on custom interactive components.
 
 # Route params & loaders
 
 - Wrap `useParams` with the provided selectors (`useProjectSelector`, `useInstanceSelector`, etc.) so required params throw during dev and produce memoized results safe for dependency arrays (`app/hooks/use-params.ts`).
-- Param selectors use React Query's `hashKey` internally to ensure stable object references across renders—same values = same object identity, preventing unnecessary re-renders.
-- Prefer `queryClient.fetchQuery` inside `clientLoader` blocks when the page needs data up front, and throw `trigger404` on real misses so the shared error boundary can render Not Found or the 403 IDP guidance (`app/pages/ProjectsPage.tsx`, `app/layouts/SystemLayout.tsx`, `app/components/ErrorBoundary.tsx`).
+- Prefer `queryClient.fetchQuery` inside `clientLoader` blocks when the page needs data up front, and throw `trigger404` on real misses so the error boundary renders Not Found.
 
 # Global stores & modals
 
@@ -100,47 +98,20 @@
 
 # UI components & styling
 
-- Reach for primitives in `app/ui` before inventing page-specific widgets; that directory intentionally holds router-agnostic building blocks (`app/ui/README.md`).
+- Reach for primitives in `app/ui` before inventing page-specific widgets; that directory holds router-agnostic building blocks.
 - When you just need Tailwind classes on a DOM element, use the `classed` helper instead of creating one-off wrappers (`app/util/classed.ts`).
-- Reuse utility components for consistent formatting—`TimeAgo`, `EmptyMessage`, `CardBlock`, `DocsPopover`, `PropertiesTable`, and friends exist so pages stay visually aligned (`app/components/TimeAgo.tsx`, `app/ui/lib`).
-
-# Docs & external links
-
-- Keep help URLs centralized: add new docs to `links`/`docLinks` and reference them when wiring `DocsPopover` or help badges (`app/util/links.ts`).
+- Reuse utility components for consistent formatting—`TimeAgo`, `EmptyMessage`, `CardBlock`, `DocsPopover`, `PropertiesTable`, etc.
+- Import icons from `@oxide/design-system/icons/react` with size suffixes: `16` for inline/table, `24` for headers/buttons, `12` for tiny indicators.
+- Keep help URLs in `links`/`docLinks` (`app/util/links.ts`).
 
 # Error handling
 
-- All API errors flow through `processServerError` in `app/api/errors.ts`, which transforms raw errors into user-friendly messages with special handling for common cases (Forbidden, ObjectNotFound, ObjectAlreadyExists).
-- On 401 errors, requests auto-redirect to `/login?redirect_uri=...` except for `loginLocal` endpoint which handles 401 in-page (`app/api/hooks.ts:49-57`).
-- On 403 errors, the error boundary automatically checks if the user has no groups and no silo role, displaying IDP misconfiguration guidance when detected (`app/components/ErrorBoundary.tsx:42-54`).
-- Throw `trigger404` (an object `{ type: 'error', statusCode: 404 }`) in loaders when resources don't exist; the error boundary will render `<NotFound />` (`app/components/ErrorBoundary.tsx`).
-
-# Validation patterns
-
-- Resource name validation: use `validateName` from `app/components/form/fields/NameField.tsx:44-60` (max 63 chars, lowercase letters/numbers/dashes, must start with letter, must end with letter or number). This matches backend validation.
-- Description validation: use `validateDescription` for max 512 char limit (`app/components/form/fields/DescriptionField.tsx`).
-- IP validation: use `validateIp` and `validateIpNet` from `app/util/ip.ts` for IPv4/IPv6 and CIDR notation—regexes match Rust `std::net` behavior for consistency.
-- All validation functions return `string | undefined` for react-hook-form compatibility.
-
-# Type utilities
-
-- Check `types/util.d.ts` for `NoExtraKeys` (catches accidental extra properties) and other type helpers.
-- Prefer `type-fest` utilities for advanced type manipulation.
-- Route param types in `app/util/path-params.ts` use `Required<Sel.X>` pattern to distinguish required path params from optional query params.
-
-# Utility functions
-
-- Check `app/util/*` for string formatting, date handling, math, IP parsing, arrays, and file utilities. Use existing helpers before writing new ones.
-
-# Icons & visual feedback
-
-- Import icons from `@oxide/design-system/icons/react` with size suffixes: `16` for inline/table use, `24` for headers/buttons, `12` for tiny indicators.
-- Use `StateBadge` for resource states, `EmptyMessage` for empty states, `HL` for highlighted text in messages.
+- All API errors flow through `processServerError` in `app/api/errors.ts`, which transforms raw errors into user-friendly messages.
+- On 401 errors, requests auto-redirect to `/login`. On 403, the error boundary checks for IDP misconfiguration.
+- Throw `trigger404` in loaders when resources don't exist; the error boundary will render Not Found.
 
-# Role & permission patterns
+# Utilities & helpers
 
-- Role helpers in `app/api/roles.ts`: `getEffectiveRole` determines most permissive role from a list, `roleOrder` defines hierarchy (admin > collaborator > viewer).
-- Use `useUserRows` hook to enrich role assignments with user/group names, sorted via `byGroupThenName` (groups first, then alphabetically).
-- Use `useActorsNotInPolicy` to fetch users/groups not already in a policy (for add-user forms).
-- Policy transformations: `updateRole` and `deleteRole` produce new policies immutably.
-- Check `userRoleFromPolicies` to determine effective user role across multiple policies (e.g., project + silo).
+- Check `app/util/*` for string formatting, date handling, IP parsing, etc. Check `types/util.d.ts` for type helpers.
+- Use `validateName` for resource names, `validateDescription` for descriptions, `validateIp`/`validateIpNet` for IPs.
+- Role helpers live in `app/api/roles.ts`.

app/components/form/ReadOnlySideModalForm.tsx

@@ -0,0 +1,55 @@
+/*
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, you can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * Copyright Oxide Computer Company
+ */
+import type { ReactNode } from 'react'
+
+import { Button } from '~/ui/lib/Button'
+import { SideModal } from '~/ui/lib/SideModal'
+
+type ReadOnlySideModalFormProps = {
+  title: string
+  subtitle?: ReactNode
+  onDismiss: () => void
+  children: ReactNode
+  /**
+   * Whether to animate the modal opening. Defaults to true. Used to prevent
+   * modal from animating in on a fresh pageload where it should already be
+   * open.
+   */
+  animate?: boolean
+}
+
+/**
+ * A read-only side modal that displays form fields in a non-editable state.
+ * Use this for "view" or "detail" modals where fields are shown but not editable.
+ */
+export function ReadOnlySideModalForm({
+  title,
+  subtitle,
+  onDismiss,
+  children,
+  animate,
+}: ReadOnlySideModalFormProps) {
+  return (
+    <SideModal
+      isOpen
+      onDismiss={onDismiss}
+      title={title}
+      subtitle={subtitle}
+      animate={animate}
+    >
+      <SideModal.Body>
+        <div className="ox-form">{children}</div>
+      </SideModal.Body>
+      <SideModal.Footer>
+        <Button variant="ghost" size="sm" onClick={onDismiss}>
+          Close
+        </Button>
+      </SideModal.Footer>
+    </SideModal>
+  )
+}

app/components/form/SideModalForm.tsx

@@ -104,7 +104,7 @@ export function SideModalForm<TFieldValues extends FieldValues>({
       <SideModal.Body>
         <form
           id={id}
-          className="ox-form is-side-modal"
+          className="ox-form"
           autoComplete="off"
           onSubmit={(e) => {
             if (!onSubmit) return

app/forms/idp/edit.tsx

@@ -6,15 +6,20 @@
  * Copyright Oxide Computer Company
  */
 import { useForm } from 'react-hook-form'
-import { useNavigate, type LoaderFunctionArgs } from 'react-router'
+import {
+  NavigationType,
+  useNavigate,
+  useNavigationType,
+  type LoaderFunctionArgs,
+} from 'react-router'
 
 import { api, q, queryClient, usePrefetchedQuery } from '@oxide/api'
 import { Access16Icon } from '@oxide/design-system/icons/react'
 
 import { DescriptionField } from '~/components/form/fields/DescriptionField'
 import { NameField } from '~/components/form/fields/NameField'
 import { TextField } from '~/components/form/fields/TextField'
-import { SideModalForm } from '~/components/form/SideModalForm'
+import { ReadOnlySideModalForm } from '~/components/form/ReadOnlySideModalForm'
 import { titleCrumb } from '~/hooks/use-crumbs'
 import { getIdpSelector, useIdpSelector } from '~/hooks/use-params'
 import { FormDivider } from '~/ui/lib/Divider'
@@ -40,24 +45,20 @@ export default function EditIdpSideModalForm() {
 
   const navigate = useNavigate()
   const onDismiss = () => navigate(pb.silo({ silo }))
+  const animate = useNavigationType() === NavigationType.Push
 
   const form = useForm({ defaultValues: idp })
 
   return (
-    <SideModalForm
-      form={form}
-      formType="edit"
-      resourceName="identity provider"
+    <ReadOnlySideModalForm
       title="Identity provider"
       onDismiss={onDismiss}
+      animate={animate}
       subtitle={
         <ResourceLabel>
           <Access16Icon /> {idp.name}
         </ResourceLabel>
       }
-      // TODO: pass actual error when this form is hooked up
-      submitError={null}
-      loading={false}
     >
       <PropertiesTable>
         <PropertiesTable.IdRow id={idp.id} />
@@ -79,7 +80,6 @@ export default function EditIdpSideModalForm() {
       <FormDivider />
 
       <SideModal.Heading>Service provider</SideModal.Heading>
-      {/* TODO: help text */}
       <TextField
         name="spClientId"
         label="Service provider client ID"
@@ -107,7 +107,6 @@ export default function EditIdpSideModalForm() {
       <FormDivider />
 
       <SideModal.Heading>Identity provider</SideModal.Heading>
-      {/* TODO: help text */}
       <TextField
         name="idpEntityId"
         label="Entity ID"
@@ -123,6 +122,6 @@ export default function EditIdpSideModalForm() {
         control={form.control}
         disabled
       />
-    </SideModalForm>
+    </ReadOnlySideModalForm>
   )
 }

app/forms/image-edit.tsx

@@ -14,7 +14,7 @@ import { Images16Icon } from '@oxide/design-system/icons/react'
 import { DescriptionField } from '~/components/form/fields/DescriptionField'
 import { NameField } from '~/components/form/fields/NameField'
 import { TextField } from '~/components/form/fields/TextField'
-import { SideModalForm } from '~/components/form/SideModalForm'
+import { ReadOnlySideModalForm } from '~/components/form/ReadOnlySideModalForm'
 import { PropertiesTable } from '~/ui/lib/PropertiesTable'
 import { ResourceLabel } from '~/ui/lib/SideModal'
 import { capitalize } from '~/util/str'
@@ -24,30 +24,28 @@ export function EditImageSideModalForm({
   image,
   dismissLink,
   type,
+  animate,
 }: {
   image: Image
   dismissLink: string
   type: 'Project' | 'Silo'
+  animate?: boolean
 }) {
   const navigate = useNavigate()
   const form = useForm({ defaultValues: image })
   const resourceName = type === 'Project' ? 'project image' : 'silo image'
+  const onDismiss = () => navigate(dismissLink)
 
   return (
-    <SideModalForm
+    <ReadOnlySideModalForm
       title={capitalize(resourceName)}
-      form={form}
-      formType="edit"
-      resourceName={resourceName}
-      onDismiss={() => navigate(dismissLink)}
+      onDismiss={onDismiss}
+      animate={animate}
       subtitle={
         <ResourceLabel>
           <Images16Icon /> {image.name}
         </ResourceLabel>
       }
-      // TODO: pass actual error when this form is hooked up
-      submitError={null}
-      loading={false}
     >
       <PropertiesTable>
         <PropertiesTable.Row label="Visibility">{type}</PropertiesTable.Row>
@@ -63,6 +61,6 @@ export function EditImageSideModalForm({
       <DescriptionField name="description" control={form.control} required disabled />
       <TextField name="os" label="OS" control={form.control} required disabled />
       <TextField name="version" control={form.control} required disabled />
-    </SideModalForm>
+    </ReadOnlySideModalForm>
   )
 }

app/forms/ssh-key-edit.tsx

@@ -6,15 +6,20 @@
  * Copyright Oxide Computer Company
  */
 import { useForm } from 'react-hook-form'
-import { useNavigate, type LoaderFunctionArgs } from 'react-router'
+import {
+  NavigationType,
+  useNavigate,
+  useNavigationType,
+  type LoaderFunctionArgs,
+} from 'react-router'
 
 import { api, q, queryClient, usePrefetchedQuery } from '@oxide/api'
 import { Key16Icon } from '@oxide/design-system/icons/react'
 
 import { DescriptionField } from '~/components/form/fields/DescriptionField'
 import { NameField } from '~/components/form/fields/NameField'
 import { TextField } from '~/components/form/fields/TextField'
-import { SideModalForm } from '~/components/form/SideModalForm'
+import { ReadOnlySideModalForm } from '~/components/form/ReadOnlySideModalForm'
 import { titleCrumb } from '~/hooks/use-crumbs'
 import { getSshKeySelector, useSshKeySelector } from '~/hooks/use-params'
 import { CopyToClipboard } from '~/ui/lib/CopyToClipboard'
@@ -41,22 +46,19 @@ export default function EditSSHKeySideModalForm() {
   const { data } = usePrefetchedQuery(sshKeyView(selector))
 
   const form = useForm({ defaultValues: data })
+  const onDismiss = () => navigate(pb.sshKeys())
+  const animate = useNavigationType() === NavigationType.Push
 
   return (
-    <SideModalForm
-      form={form}
-      formType="edit"
-      resourceName="SSH key"
+    <ReadOnlySideModalForm
       title="View SSH key"
-      onDismiss={() => navigate(pb.sshKeys())}
+      onDismiss={onDismiss}
+      animate={animate}
       subtitle={
         <ResourceLabel>
           <Key16Icon /> {data.name}
         </ResourceLabel>
       }
-      // TODO: pass actual error when this form is hooked up
-      loading={false}
-      submitError={null}
     >
       <PropertiesTable>
         <PropertiesTable.IdRow id={data.id} />
@@ -77,6 +79,6 @@ export default function EditSSHKeySideModalForm() {
           disabled
         />
       </div>
-    </SideModalForm>
+    </ReadOnlySideModalForm>
   )
 }

app/hooks/use-params.ts

@@ -46,6 +46,7 @@ export const getSiloImageSelector = requireParams('image')
 export const getSshKeySelector = requireParams('sshKey')
 export const getIdpSelector = requireParams('silo', 'provider')
 export const getProjectImageSelector = requireParams('project', 'image')
+export const getDiskSelector = requireParams('project', 'disk')
 export const getProjectSnapshotSelector = requireParams('project', 'snapshot')
 export const requireSledParams = requireParams('sledId')
 export const requireUpdateParams = requireParams('version')
@@ -81,6 +82,7 @@ function useSelectedParams<T>(getSelector: (params: AllParams) => T) {
 export const useFloatingIpSelector = () => useSelectedParams(getFloatingIpSelector)
 export const useProjectSelector = () => useSelectedParams(getProjectSelector)
 export const useProjectImageSelector = () => useSelectedParams(getProjectImageSelector)
+export const useDiskSelector = () => useSelectedParams(getDiskSelector)
 export const useSshKeySelector = () => useSelectedParams(getSshKeySelector)
 export const useProjectSnapshotSelector = () =>
   useSelectedParams(getProjectSnapshotSelector)

app/pages/SiloImageEdit.tsx

@@ -5,7 +5,7 @@
  *
  * Copyright Oxide Computer Company
  */
-import { type LoaderFunctionArgs } from 'react-router'
+import { NavigationType, useNavigationType, type LoaderFunctionArgs } from 'react-router'
 
 import { api, q, queryClient, usePrefetchedQuery } from '@oxide/api'
 
@@ -28,6 +28,14 @@ export const handle = titleCrumb('Edit Image')
 export default function SiloImageEdit() {
   const selector = useSiloImageSelector()
   const { data } = usePrefetchedQuery(imageView(selector))
+  const animate = useNavigationType() === NavigationType.Push
 
-  return <EditImageSideModalForm image={data} dismissLink={pb.siloImages()} type="Silo" />
+  return (
+    <EditImageSideModalForm
+      image={data}
+      dismissLink={pb.siloImages()}
+      type="Silo"
+      animate={animate}
+    />
+  )
 }