Upgrade typescript-eslint to v8 and fix lints (#2400)

upgrade ts-eslint to v8 and fix lints

Author: david-crespo

.eslintrc.cjs

@@ -42,25 +42,29 @@ module.exports = {
     '@typescript-eslint/consistent-type-definitions': 'off',
     '@typescript-eslint/consistent-type-imports': ['error', { prefer: 'type-imports' }],
     '@typescript-eslint/no-empty-function': 'off',
-    '@typescript-eslint/no-empty-interface': 'off',
     '@typescript-eslint/ban-ts-comment': 'off',
+    '@typescript-eslint/no-empty-object-type': [
+      'error',
+      { allowInterfaces: 'with-single-extends' },
+    ],
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/no-duplicate-type-constituents': 'off',
     '@typescript-eslint/no-unused-vars': [
       'error',
-      { argsIgnorePattern: '^_', varsIgnorePattern: '^_' },
+      { argsIgnorePattern: '^_', varsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' },
     ],
 
     // disabling the type-aware rules we don't like
     // https://typescript-eslint.io/getting-started/typed-linting/
     '@typescript-eslint/no-floating-promises': 'off',
     '@typescript-eslint/no-misused-promises': 'off',
-    '@typescript-eslint/unbound-method': 'off',
     '@typescript-eslint/no-unsafe-argument': 'off',
     '@typescript-eslint/no-unsafe-assignment': 'off',
     '@typescript-eslint/no-unsafe-call': 'off',
     '@typescript-eslint/no-unsafe-member-access': 'off',
     '@typescript-eslint/no-unsafe-return': 'off',
+    '@typescript-eslint/only-throw-error': 'off',
+    '@typescript-eslint/unbound-method': 'off',
 
     eqeqeq: ['error', 'always', { null: 'ignore' }],
     'import/no-default-export': 'error',

app/components/form/fields/NetworkInterfaceField.tsx

@@ -61,9 +61,11 @@ export function NetworkInterfaceField({
               setOldParams(value.params)
             }
 
-            newType === 'create'
-              ? onChange({ type: newType, params: oldParams })
-              : onChange({ type: newType })
+            if (newType === 'create') {
+              onChange({ type: newType, params: oldParams })
+            } else {
+              onChange({ type: newType })
+            }
           }}
           disabled={disabled}
         >

app/forms/disk-create.tsx

@@ -122,7 +122,11 @@ export function CreateDiskSideModalForm({
       onDismiss={() => onDismiss(navigate)}
       onSubmit={({ size, ...rest }) => {
         const body = { size: size * GiB, ...rest }
-        onSubmit ? onSubmit(body) : createDisk.mutate({ query: { project }, body })
+        if (onSubmit) {
+          onSubmit(body)
+        } else {
+          createDisk.mutate({ query: { project }, body })
+        }
       }}
       loading={createDisk.isPending}
       submitError={createDisk.error}

app/forms/image-upload.tsx

@@ -770,8 +770,9 @@ async function readAtOffset(file: File, offset: number, length: number) {
     }
 
     reader.onerror = (error) => {
-      console.error(`Error reading file at offset ${offset}:`, error)
-      reject(error)
+      const msg = `Error reading file at offset ${offset}:`
+      console.error(msg, error)
+      reject(new Error(msg))
     }
   })
 

app/layouts/RootLayout.tsx

@@ -88,6 +88,7 @@ function LoadingBar() {
             // condition, we'd immediately kill an in-progress loading animation
             // that was about to finish on its own anyway.
             barRef.current?.classList.remove('loading', 'done')
+            // eslint-disable-next-line @typescript-eslint/no-unused-expressions
             barRef.current?.scrollTop
 
             // Kick off the animation

app/pages/project/instances/instance/tabs/MetricsTab.tsx

@@ -205,7 +205,7 @@ export function MetricsTab() {
           selected={diskName}
           items={diskItems}
           onChange={(val) => {
-            val && setDiskName(val)
+            if (val) setDiskName(val)
           }}
         />
         {dateTimeRangePicker}

app/ui/lib/AuthCodeInput.tsx

@@ -124,7 +124,7 @@ export const AuthCodeInput = forwardRef<AuthCodeRef, AuthCodeProps>(
         .map((input) => input.value)
         .join('')
         .toUpperCase()
-      onChange && onChange(res)
+      onChange?.(res)
     }
 
     const handleOnChange = (e: React.ChangeEvent<HTMLInputElement>) => {

mock-api/msw/db.ts

@@ -19,8 +19,6 @@ import { commaSeries } from '~/util/str'
 import type { Json } from '../json-type'
 import { internalError } from './util'
 
-const notFoundBody = { error_code: 'ObjectNotFound' } as const
-export type NotFound = typeof notFoundBody
 export const notFoundErr = (msg: string) => {
   const message = `not found: ${msg}`
   return json({ error_code: 'ObjectNotFound', message } as const, { status: 404 })