Bump deprecated GH actions (#2323)

* bump actions and see what happens

* try to get the path right

* add comment, don't upload assets on PRs

Author: david-crespo

.github/workflows/license-check.yml

@@ -13,6 +13,6 @@ jobs:
   license:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Check License Header
         uses: apache/skywalking-eyes/header@5dfa68f93380a5e57259faaf95088b7f133b5778

.github/workflows/reformatter.yaml

@@ -10,11 +10,11 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
           cache: 'npm'
 
       - name: Install dependencies

.github/workflows/upload-assets.yaml

@@ -9,19 +9,19 @@ jobs:
   build-and-upload:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: 'npm'
       - name: 'Authenticate to Google Cloud'
-        uses: 'google-github-actions/auth@v1'
+        uses: 'google-github-actions/auth@v2'
         with:
           credentials_json: '${{ secrets.GOOGLE_CLOUD_DL_SA }}'
       - name: Set up Cloud SDK
-        uses: google-github-actions/setup-gcloud@v1
+        uses: google-github-actions/setup-gcloud@v2
         with:
           project_id: oxide-downloads
-      - uses: actions/setup-node@v3
-        with:
-          node-version: 18
-          cache: 'npm'
       - run: npm install
       - name: Build for Nexus
         run: SHA=${{ github.sha }} npm run build
@@ -36,7 +36,12 @@ jobs:
         run: sha256sum releases/console/${{ github.sha }}.tar.gz | awk '{print $1}' > releases/console/${{ github.sha }}.sha256.txt
       - name: Upload files to GCP bucket
         id: upload-files
-        uses: google-github-actions/upload-cloud-storage@v0.9.0
+        uses: google-github-actions/upload-cloud-storage@v2
         with:
+          # weird combo: the path tells it where to find the files, and for some
+          # reason it takes only the immediate containing folder name and sticks
+          # it in the destination, so we end up with dl.oxide.computer/releases/console,
+          # as desired
           path: 'releases/console'
-          destination: 'dl.oxide.computer'
+          destination: 'dl.oxide.computer/releases'
+          process_gcloudignore: false # we don't have one