Skip to content

Commit e2d82a4

Browse files
Firewall rule improvements (#1887)
* Table improvements - Make name clickable - Add direction column - Improve action casing * Firewall rule form improvements * Use same labels as API * Test titleCase * Checkout `CheckboxGroup` from `ssh-key-select` * Add `CheckboxGroupField` * Remove unused prop * Disable grouping (commas) on number field * Fix test * Actually fix test * undo checkbox thing * prefetch subnets and firewall rules, sort by priority, better col order * Blocking out routes (incomplete) * Revert "Blocking out routes (incomplete)" This reverts commit 16deaac. * remove redundant/incorrect test from chatgpt * undo checkbox changes * postpone clickable name until next PR * epic e2e tests for fiddly hosts and targets tables, fix two bugs! * do hosts and targets logic slightly nicer --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
1 parent d6a67bd commit e2d82a4

File tree

8 files changed

+403
-211
lines changed

8 files changed

+403
-211
lines changed

app/components/form/fields/NumberField.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,9 @@ export const NumberFieldInner = <
9090
aria-describedby={tooltipText ? `${id}-label-tip` : undefined}
9191
isDisabled={disabled}
9292
{...field}
93+
formatOptions={{
94+
useGrouping: false,
95+
}}
9396
/>
9497
<ErrorMessage error={error} label={label} />
9598
</>

app/components/form/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export * from './fields/ImageSelectField'
1919
export * from './fields/ListboxField'
2020
export * from './fields/NameField'
2121
export * from './fields/NetworkInterfaceField'
22+
export * from './fields/NumberField'
2223
export * from './fields/RadioField'
2324
export * from './fields/SubnetListbox'
2425
export * from './fields/TextField'

0 commit comments

Comments
 (0)