Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With modal on top of side modal form, second overlay does not cover side modal #2564

Open
david-crespo opened this issue Nov 19, 2024 · 0 comments

Comments

@david-crespo
Copy link
Collaborator

This affects confirm nav on side modal form as well as the image upload form. Demo video from #2328 (comment) shows the approach of simply turning off the overlay for the second modal. But for image upload this feels less good because the modal is up for a while and there's a lot going on in both the upload modal and the side modal form. So the better fix would be to show the overlay but give it a higher z-index when it's on top of the side modal so that it can cover the side modal form as well. Now that I write this out, it occurs to me that it might work to simply always give the modal and its overlay that high z-index.

2024-11-19-modal-hide-overlay.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant