does not build on illumos

[davepacheco]

I'm not sure if this matters now, or at all, but I wanted to record this in case anybody else runs into it.

I tried to build using the instructions in the README. This was basically just cloning the repo and running npm install --global corepack (to get yarn) and then yarn install. I had Node 16.3.0 and yarn 1.22.15.

yarn install command bailed out here:

[3/4] Linking dependencies...
warning "recharts > react-smooth@2.0.0" has unmet peer dependency "prop-types@^15.6.0".
[4/4] Building fresh packages...
[6/6] ⠐ esbuild
[-/6] ⠐ waiting...
[3/6] ⠐ core-js-pure
[4/6] ⠐ esbuild
error /home/dap/console/node_modules/esbuild: Command failed.
Exit code: 1
Command: node install.js
Arguments: 
Directory: /home/dap/console/node_modules/esbuild

(that's the end of the output -- a bunch of blank lines)

With yarn install --verbose, I got a bit more detail:

verbose 16.142809398 Error: /home/dap/console/node_modules/esbuild: Command failed.
Exit code: 1
Command: node install.js
Arguments: 
Directory: /home/dap/console/node_modules/esbuild
Output:
Unsupported platform: sunos x64 LE
    at ProcessTermError.ExtendableBuiltin (/home/dap/.node/corepack/yarn/1.22.15/lib/cli.js:721:66)
    at ProcessTermError.MessageError (/home/dap/.node/corepack/yarn/1.22.15/lib/cli.js:750:123)
    at new ProcessTermError (/home/dap/.node/corepack/yarn/1.22.15/lib/cli.js:790:113)
    at ChildProcess.<anonymous> (/home/dap/.node/corepack/yarn/1.22.15/lib/cli.js:25783:17)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
error /home/dap/console/node_modules/esbuild: Command failed.

@david-crespo found this potentially related PR:
evanw/esbuild#1562

[david-crespo]

According to the changelog, the Illumos support PR made it into esbuild v0.12.25. Vite 2.6, which is where our esbuild dep comes from, is pinned to esbuild ^0.13.2. So we should have it.

However:

~/oxide/console $ yarn why esbuild
yarn why v1.22.17
[1/4] 🤔  Why do we have the module "esbuild"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "esbuild@0.12.20"
info Has been hoisted to "esbuild"
info This module exists because it's specified in "devDependencies".
info Disk size without dependencies: "7.81MB"
info Disk size with unique dependencies: "7.81MB"
info Disk size with transitive dependencies: "7.81MB"
info Number of shared dependencies: 0
=> Found "vite#esbuild@0.13.15"
info This module exists because "vite" depends on it.
info Disk size without dependencies: "124KB"
info Disk size with unique dependencies: "124KB"
info Disk size with transitive dependencies: "124KB"
info Number of shared dependencies: 0
✨  Done in 0.35s.

It turned out I had pinned esbuild 0.12.14 as a top-level dependency for, as far as I can tell, no reason. Fixed in 3560e24. Will close this issue once we confirm this fixes it.

[david-crespo]

Ok, @davepacheco confirms it works now.

And for the record I figured out why I included an explicit esbuild dep:

console/vite.config.js

Line 4 in 3560e24

import esbuild from 'esbuild'