Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instance create] GB should be GiB #734

Closed
david-crespo opened this issue Mar 25, 2022 · 2 comments · Fixed by #760
Closed

[Instance create] GB should be GiB #734

david-crespo opened this issue Mar 25, 2022 · 2 comments · Fixed by #760
Assignees
@zephraph

Comments

@david-crespo
Copy link
Collaborator

Per RFD 203 Standard units for counting bits. Right now they're GB.

image
@benjaminleonard
Copy link
Contributor

Is there a way to write some really light helpers that take a byte value and convert it to the appropriate unit? That way we can make sure we're using the correct unit across the board?

@zephraph
Copy link
Contributor

We have that in a library already, but yeah we could do a smaller helper.

@zephraph zephraph mentioned this issue Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zephraph zephraph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert instance form oxidecomputer/console
3 participants
@zephraph @david-crespo @benjaminleonard