default compression: false

Author: david-crespo

dropshot/src/config.rs

@@ -123,7 +123,7 @@ impl Default for ConfigDropshot {
             default_request_body_max_bytes: 1024,
             default_handler_task_mode: HandlerTaskMode::Detached,
             log_headers: Default::default(),
-            compression: true,
+            compression: false,
         }
     }
 }

dropshot/tests/integration-tests/config.rs

@@ -66,7 +66,7 @@ fn test_valid_config_all_settings() {
             default_request_body_max_bytes: 1048576,
             default_handler_task_mode: HandlerTaskMode::CancelOnDisconnect,
             log_headers: vec!["X-Forwarded-For".to_string()],
-            compression: true,
+            compression: false,
         },
     );
 }

dropshot/tests/integration-tests/gzip.rs

@@ -15,10 +15,29 @@ use hyper::body::Frame;
 use hyper::{Request, Response};
 use serde::{Deserialize, Serialize};
 
-use crate::common::{create_log_context, test_setup};
+use crate::common::create_log_context;
 
 extern crate slog;
 
+// Helper function for tests in this file
+// Since we're testing gzip compression, most tests need compression enabled
+fn test_setup(
+    test_name: &str,
+    api: ApiDescription<usize>,
+) -> dropshot::test_util::TestContext<usize> {
+    let config =
+        dropshot::ConfigDropshot { compression: true, ..Default::default() };
+    let logctx = create_log_context(test_name);
+    let log = logctx.log.new(slog::o!());
+    dropshot::test_util::TestContext::new(
+        api,
+        0_usize,
+        &config,
+        Some(logctx),
+        log,
+    )
+}
+
 // Helper functions for tests
 
 /// Creates a request builder with gzip Accept-Encoding header