Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust minimum version needs to be bumped #142

Open
rmustacc opened this issue Feb 24, 2024 · 1 comment
Open

rust minimum version needs to be bumped #142

rmustacc opened this issue Feb 24, 2024 · 1 comment

Comments

@rmustacc
Copy link
Contributor

While building on a system that had a slightly older toolchain, I noticed the following build error:

$ gmake setup
cd tools/helios-build && cargo build --quiet
error[E0658]: use of unstable library feature 'is_terminal'
 --> src/common.rs:8:5
  |
8 | use std::io::IsTerminal;
  |     ^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #98070 <https://github.com/rust-lang/rust/issues/98070> for more information

error[E0658]: use of unstable library feature 'is_terminal'
  --> src/common.rs:20:26
   |
20 |     if std::io::stdout().is_terminal() {
   |                          ^^^^^^^^^^^
   |
   = note: see issue #98070 <https://github.com/rust-lang/rust/issues/98070> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `helios-build` due to 2 previous errors

It appears that the minimum version needs to be bumped to something like 1.70 per https://github.com/rust-lang/rust/releases/tag/1.70.0.

@rmustacc
Copy link
Contributor Author

I'm not sure if there's anything other than 1.70 related features as this environment was updated then to 1.76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant