Skip to content

Commit d1fd755

Browse files
authored
Fix oximeter schema change comment (#9350)
Follow up to #9341 (comment)
1 parent e97647d commit d1fd755

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

oximeter/db/schema/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@ transactions, we actually require that there are no writes of any kind. In
2121
practice, this means `oximeter` **must not** be running when this is called.
2222
Similarly, there must be only a single instance of this program at a time.
2323

24-
_NB: Schema changes for the `oximeter` database are currently disabled due to
25-
ongoing self-service update work. More information about this restriction can
26-
be found in [#8862](https://github.com/oxidecomputer/omicron/issues/8862)_
24+
_NB: Schema changes for the `oximeter` database are not allowed because there
25+
is no mechanism to apply them to existing systems. If we need to support schema
26+
changes at some point, we'll have to do the work to update them during automated
27+
update. See omicron [#8862](https://github.com/oxidecomputer/omicron/issues/8862)
28+
for details._
2729

2830
To run this program:
2931

oximeter/db/tests/integration_test.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,11 @@ impl TestInput {
4343
/// Ensure the oximeter database schemas for both single node and replicated
4444
/// cluster are not modified.
4545
///
46-
/// Schema changes for the `oximeter` database are currently disabled due to
47-
/// ongoing self-service update work. More information about this restriction
48-
/// can be found in https://github.com/oxidecomputer/omicron/issues/8862
46+
/// Schema changes for the `oximeter` database are not allowed because there is
47+
/// no mechanism to apply them to existing systems. If we need to support schema
48+
/// changes at some point, we'll have to do the work to update them during
49+
/// automated update. See https://github.com/oxidecomputer/omicron/issues/8862
50+
/// for details.
4951
#[tokio::test]
5052
async fn test_schemas_are_not_modified() -> anyhow::Result<()> {
5153
let cur_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));

0 commit comments

Comments
 (0)