Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unauthorized" test should support more-public endpoints #1277

Open
Tracked by #419
davepacheco opened this issue Jun 24, 2022 · 1 comment
Open
Tracked by #419

"unauthorized" test should support more-public endpoints #1277

davepacheco opened this issue Jun 24, 2022 · 1 comment

Comments

@davepacheco
Copy link
Collaborator

Several endpoints are in the list of endpoints uncovered by the authz test because they're essentially public -- all authenticated users can access them. This includes the ssh key endpoints and after #1261 it will include the endpoint to list users in the Silo. We could augment the "unauthorized" test to better support these: it would still verify that unauthorized users get a 401, and it could verify that authenticated users get a 200. It's tempting to have it check that all authorized users get the same result, but that won't be true for things like the ssh keys endpoint because they'll have different keys (with different ids if nothing else).

@jmpesp
Copy link
Contributor

jmpesp commented Jul 1, 2022

Addressed a few in #1341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants