You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
at least, it's extremely likely it's carriage returns that come with long lines, something to that effect.
#756 landed with this kind of hokey workround: when writing a very long line to a guest, PHD would appear to hang. it's certainly that PHD is waiting for the guest to echo back what it wrote, but the guest wrote \r\n and the expected character is just a bit beyond that.
whatever it is, this really ought to be fixed in PHD, rather than a one-off helper in boot_order.rs.
The text was updated successfully, but these errors were encountered:
i did eventually take a look at doing something... better here, the options don't seem great.
theoretically there is a dumb or vanilla terminal type that should have ~infinite (65535?) columns, and so we'd practically never line wrap. that would be convenient. in practice Linuxes don't seem to like this much on PTYs for reasons i haven't dug into.
we can stty a very wide terminal, and we can put that in .profile or somewhere in guests so it's automatically set on boot, or include it as part of the login sequence. this works well for Linux guests! as in, it would be perfect. but somewhere between Windows, the SAC, and Cygwin, this doesn't actually take effect for Windows guests, so they still send control characters once you hit 80 columns
we can emulate receiving text as an 80 column terminal instead of just prefix matching on waits here. that is, when we get a new line of text we'd un-wrap it if we have read 80 characters since the last newline and then try to find the right strings int hat unwrapped buffer. this will probably work as long as guests think they are driving a terminal exactly 80 characters wide.
at least, it's extremely likely it's carriage returns that come with long lines, something to that effect.
#756 landed with this kind of hokey workround: when writing a very long line to a guest, PHD would appear to hang. it's certainly that PHD is waiting for the guest to echo back what it wrote, but the guest wrote
\r\n
and the expected character is just a bit beyond that.whatever it is, this really ought to be fixed in PHD, rather than a one-off helper in
boot_order.rs
.The text was updated successfully, but these errors were encountered: