New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sihl.Database.query should raise error #419

Open

joseferben opened this issue Mar 6, 2021 · 0 comments

Labels

bug good first issue

Contributor

joseferben commented Mar 6, 2021

Currently a query looks like

let get ~id =
    Database.query (fun connection ->
        let module Connection = (val connection : Caqti_lwt.CONNECTION) in
        Connection.find_opt get_request id |> Lwt.map Database.raise_error)
  ;;

instead we could get rid of raise_error and just have

  let get ~id =
    Database.query (fun connection ->
        let module Connection = (val connection : Caqti_lwt.CONNECTION) in
        Connection.find_opt get_request id)
  ;;

The text was updated successfully, but these errors were encountered:

joseferben added bug good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment