Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend session API #524

Open
aronerben opened this issue Nov 18, 2021 · 0 comments
Open

Extend session API #524

aronerben opened this issue Nov 18, 2021 · 0 comments

Comments

@aronerben
Copy link
Contributor

Various functions in web_session.ml can only be used for either Response.t or Request.t, for example val find : ... -> Request.t -> string option. For symmetry purposes, extend the API so all these functions have duals, one for requests and one for responses (where it makes sense).

Additionally, rethink the semantic for set_value, as it currently also takes a request. Should the session be maintained this way? An alternative is to just delete the request argument and leave that handling to the user. Find out what's more ergonomic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant