Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to scratch breaking? #171

Closed
theogf opened this issue Feb 12, 2024 · 1 comment · Fixed by #172
Closed

Change to scratch breaking? #171

theogf opened this issue Feb 12, 2024 · 1 comment · Fixed by #172

Comments

@theogf
Copy link

theogf commented Feb 12, 2024 •
edited
Loading

Isn't the change to use Scratch.jl breaking?
Specifically this line:

https://github.com/oxinabox/DataDeps.jl/pull/167/files#diff-5b81a76e4a8ea96c096d34b1c4e05817631e527cf6300068c1c0ea3ceb7d9d8eL5

If I had my data in .julia/datadeps, specifically by adding it there manually, now DataDeps.jl is completely unable to find it.

For retrocompatibility, it would be good to keep Base.DEPOT_PATH in the standard_paths ?
@oxinabox
Copy link
Owner

Yes, good point we can keep it in there, just lower down so it is still read but not written to.
I will PR presently

@oxinabox oxinabox mentioned this issue Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep reading from DEPOT_PATH (but don't write to by default) oxinabox/DataDeps.jl
2 participants
@oxinabox @theogf