Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate SHOW_ELAPSED_TIME properties to address v8r error #1962

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Deduplicate SHOW_ELAPSED_TIME properties to address v8r error #1962

merged 2 commits into from
Oct 12, 2022

Conversation

proinsias
Copy link
Contributor

@proinsias proinsias commented Oct 12, 2022

Proposed Changes

If you run the v8r tool on a .mega-linter.yml file that contains a SHOW_ELAPSED_TIME key, you will get the following error:

ℹ Processing .mega-linter.yml
ℹ Found schema in https://www.schemastore.org/api/json/catalog.json ...
ℹ Validating .mega-linter.yml against schema from https://raw.githubusercontent.com/megalinter/megalinter/main/megalinter/descriptors/schemas/megalinter-configuration.jsonschema.json ...
✖ reference "http://github.com/oxsecurity/megalinter-configuration.json#/properties/SHOW_ELAPSED_TIME" resolves to more than one schema

This is because the megalinter/descriptors/schemas/megalinter-configuration.jsonschema.json file has two SHOW_ELAPSED_TIME properties due to a typo. This PR fixes this typo.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for your contribution :)

@nvuillam nvuillam merged commit de6754f into oxsecurity:main Oct 12, 2022
@proinsias proinsias deleted the proinsias-deduplicate-SHOW_ELAPSED_TIME branch October 12, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants