Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New linter idea: woke #2535

Closed
DariuszPorowski opened this issue Apr 6, 2023 · 8 comments
Closed

New linter idea: woke #2535

DariuszPorowski opened this issue Apr 6, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@DariuszPorowski
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Idea is to add https://github.com/get-woke/woke as part of the megalinter. Woke scans source code for non-inclusive language and suggest alternatives.

Describe the solution you'd like

woke part of megalinter

Describe alternatives you've considered

N/A

Additional context

N/A

@DariuszPorowski DariuszPorowski added the enhancement New feature or request label Apr 6, 2023
@nvuillam
Copy link
Member

nvuillam commented Apr 6, 2023

I think it will be red for 99% of the repos, including MegaLinter, but progress is also driven by open source, so I'd be glad to accept the PR ;)

You can flag it as a formatter so it won't be blocking by default:)

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label May 7, 2023
@nvuillam
Copy link
Member

@DariuszPorowski still interested to add this linter someday ? :)

@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label May 11, 2023
@DariuszPorowski
Copy link
Contributor Author

@nvuillam yep, even have (almost) working code... minor adjustments required, but before I open PR for this one i want to make sure this PR is closed: #2504 gentle follow-up for review :)

@nvuillam
Copy link
Member

@DariuszPorowski I made too many (great !) enhancements , and now the current main branch is kind of broken ... so all PR CI jobs are broken ... but when I'll have solved #2611 , all the other PR's will be revived, including yours of course :)

@DariuszPorowski
Copy link
Contributor Author

Just thinking more about this proposal... , woke is great but it looks like it's a stale project and not maintained anymore :(

@Kurt-von-Laven
Copy link
Collaborator

Thanks for letting us know. Yeah, that is an important consideration since we don't want our users stuck in a situation where a security vulnerability isn't addressed in a timely manner. Closing this issue for now then, but anyone should feel free to request that it be reopened if woke becomes actively maintained in the future.

@nvuillam
Copy link
Member

@DariuszPorowski thanks for the heads up, indeed in v7 we remove linters not maintained for a while , so it would be sad to add a new one ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants