Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links for Pylint in python.megalinter-descriptor.yml #3116

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Nov 15, 2023

Fixes lychee in CI with Pylint as the URLs of their project has changed in the last year.

See
pylint-dev/pylint#8934

pylint-dev/pylint#7384 (comment)

Proposed Changes

  1. I didn’t find the equivalent of the banner like https://web.archive.org/web/20221208035018/https://megalinter.io/latest/descriptors/python_pylint/, except on Wikimedia commons. I wouldn’t want to hotlink them. So I only used the icon that exists in the repo.
  2. Updated the various links for Pylint in the descriptor.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix
Copy link
Collaborator Author

echoix commented Nov 15, 2023

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed updating files.

Copy link
Contributor

github-actions bot commented Nov 15, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 5 0 0.05s
✅ BASH shellcheck 5 0 0.15s
✅ BASH shfmt 5 0 0 0.51s
✅ COPYPASTE jscpd yes no 4.39s
✅ DOCKERFILE hadolint 124 0 14.3s
✅ JSON eslint-plugin-jsonc 23 0 0 4.22s
✅ JSON jsonlint 21 0 0.62s
✅ JSON v8r 23 0 18.35s
✅ MAKEFILE checkmake 1 0 0.03s
⚠️ MARKDOWN markdownlint 256 0 11 7.52s
✅ MARKDOWN markdown-link-check 256 0 8.18s
✅ MARKDOWN markdown-table-formatter 256 0 0 51.79s
✅ OPENAPI spectral 1 0 2.67s
⚠️ PYTHON bandit 201 61 3.92s
✅ PYTHON black 201 0 0 4.84s
✅ PYTHON flake8 201 0 2.83s
✅ PYTHON isort 201 0 0 1.14s
✅ PYTHON mypy 201 0 14.04s
✅ PYTHON pylint 201 0 15.98s
⚠️ PYTHON pyright 201 352 23.77s
✅ PYTHON ruff 201 0 0 0.57s
✅ REPOSITORY checkov yes no 39.65s
✅ REPOSITORY git_diff yes no 0.51s
⚠️ REPOSITORY grype yes 1 26.46s
✅ REPOSITORY secretlint yes no 10.96s
✅ REPOSITORY trivy yes no 38.56s
✅ REPOSITORY trivy-sbom yes no 14.92s
⚠️ REPOSITORY trufflehog yes 1 19.37s
✅ SPELL cspell 668 0 30.25s
✅ SPELL lychee 336 0 6.6s
✅ XML xmllint 3 0 0 0.51s
✅ YAML prettier 160 0 0 8.18s
✅ YAML v8r 102 0 151.05s
✅ YAML yamllint 161 0 2.78s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator Author

echoix commented Nov 15, 2023

To merge promptly to unblock other CI failing checks!

@echoix echoix enabled auto-merge (squash) November 15, 2023 01:24
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great <3

@echoix echoix merged commit a55132b into main Nov 15, 2023
126 checks passed
@echoix echoix deleted the fix-pylint branch November 15, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants