Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript TSD Definitions #6

Closed
sparebytes opened this issue Dec 28, 2016 · 2 comments
Closed

Typescript TSD Definitions #6

sparebytes opened this issue Dec 28, 2016 · 2 comments

Comments

@sparebytes
Copy link

Here is my quick and dirty typescript definition files in case anyone else could use it.
https://gist.github.com/sparebytes/5964fa0a41db22ee8a99a6cf7f1f8c3b

I noticed that some places refer to DB and others refer to Db so I changed everything to use DB.

@ozum
Copy link
Owner

ozum commented Dec 29, 2016

Hi,

Thank you for indicating inconsistencies in documentation. Correct one is Db. I updated all references consistently as Db.

Could you please update your definition.

One more thing. I have no experience on typescript. Should I include definition file to pg-structure and if yes, where?

Also thank you for the contribution.

@sparebytes
Copy link
Author

sparebytes commented Dec 29, 2016

Glad to help. I made a pull request for you and tested the changes on my local system. One thing I did was add a dependency to @types/db. Some people are inclined to add it to devDependencies instead but that adds extra work for users of your library ( see microsoft/types-publisher#81 )

@ozum ozum closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants