Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepConnection should be true by default if pg.Client or pg.Pool is passed #70

Open
andreypopp opened this issue Feb 16, 2022 · 1 comment
Open

keepConnection should be true by default if pg.Client or pg.Pool is passed #70

andreypopp opened this issue Feb 16, 2022 · 1 comment
Labels
enhancement

Comments

@andreypopp
Copy link

Hi,

Thanks for the pg-structure!

Just some feedback on API ergonomics. I think it would make API more ergonomic if pg-structure would keep connections open if it passed pg.Client or pg.Pool — the justification is that if a user passed an initialised connection then they are responsible for its lifecycle.
@ozum
Copy link
Owner

ozum commented Feb 18, 2022

Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreypopp @ozum