Display the app icon, from which the text was copied

[Romachamp]

Before Submitting Your Feature Request

• Check that there isn't already a similar feature request to avoid creating a duplicate.
• I have seen the FAQ.

Problem

Hello! I’ve used Maccy for a long time, but the main issue I faced was not being able to instantly see, from where I copied the item. Later, I discovered I can see the app, from where I copied, but it isn’t displayed next to it, so I must click on the item to get this information.

Solution

The solution I want is the app icon, from where the item is copied, right next to it. In this way, I can instantly see, from where I copied anything.

Alternatively, you could provide an option in the settings to display app icon next to the copied item, instead of the keyboard shortcut to paste that item. It would be more handy for me personally.

[p0deje]

You can see the source app in the preview, which can be shown instantly by changing Preview Delay. Is this enough for your needs?

[Romachamp]

Well, I’ve used this feature. However, in the preview the app is shown by the text and it still isn’t that handy. With app icon right next to the copied icon, I would be able to see it instantly and it would be more handy to me.

[Romachamp]

@p0deje you could add an option to the settings to show the app icon, instead of keyboard shortcuts, so people can decide what’s more handy for them. What do you think about it?

[p0deje]

I am open to merge PRs adding support for this, but I don't have capacity to implement it myself at the moment.

[weisJ]

I have this actually implemented in the branch where I keep my custom changes: ab9fb0a

I don't have a lot of time to clean it up and connect it to the settings, however it is a good starting point @Romachamp

[p0deje]

I have this actually implemented in the branch where I keep my custom changes: ab9fb0a

Screenshots or didn't happen.

[weisJ]

Fair enough :D

[Romachamp]

Awesome, this is exactly what I wanted. It would be awesome, if it were in the app.

[Romachamp]

@p0deje Will you implement this feature now, since there is a pull request?

[p0deje]

@Romachamp There is no PR yet.
@weisJ Are you up to create a PR with this? We'd need a checkbox in Appearance setting to turn it on (with off by default) and localizations for it in all languages (I can help with that).

[weisJ]

I can create a PR. Still have to do some cleanup. Currently not satisfied with how I am handling missing icons. Also the cache needs to have some eviction strategy to ensure icons get updated when they change.

I would also add the icon to the preview popover next to the application name. Should this be toggled through the same settings switch or always be visible?

[p0deje]

I can create a PR. Still have to do some cleanup. Currently not satisfied with how I am handling missing icons. Also the cache needs to have some eviction strategy to ensure icons get updated when they change.

I haven't looked through the code, but I'll trust your judgement with whatever is the best here.

I would also add the icon to the preview popover next to the application name. Should this be toggled through the same settings switch or always be visible?

I think it's fine to always show in the preview, maybe with a different size to make it more compact.

[Romachamp]

Good point, I also think it’s fine to show the icon in the preview as well, but a bit smaller.

[Romachamp]

@weisJ Will you be able to fully implement this new feature into Maccy, after polishing the code a bit?

[Romachamp]

@p0deje There is now a PR. Will there be this feature any soon in Maccy?