Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclasses not correctly re-cast after roundtrip json serialization #34

Open
sneakers-the-rat opened this issue Oct 11, 2024 · 0 comments

Comments

@sneakers-the-rat
Copy link
Collaborator

If a model annotation specifies some parent class, but a subclass is given to the model, when roundtripping the model to and from json, the data is cast back into the parent type since that's what's on the model. need an additional annotation in the dumped json to indicate the dtype class to cast back into. marking as an xfail in the tests for now

revealed in: #31

want to merge that before trying to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant