-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll back if sub-channel is stuck in Offered
or CloseOffered
#120
Comments
This has come up recently again whilst working on 10101. What do you think, @Tibo-lg? |
For the "regular" dlc channels there is a timeout mechanism, which IIRC simply force closes the channel after some time if the peer doesn't answer a message in a timely manner. Rolling back could also work I guess, I don't have a strong opinion, but maybe take a look at the implementation for the dlc channels and see if you think that would fit with what you had in mind. |
We would like to be able to roll back to a previous state if a sub-channel protocol cannot make progress for whatever reason and it is safe to forget about all the information that has been exchanged thus far.
One such instance is after a channel update has been offered (
Offered
andCloseOffered
states). Once #116 is merged I think theAccepted
state can also be rolled back since we no longer send the new split transaction signature with it. I don't think we can treatCloseAccepted
the same way because theSubChannelCloseAccept
message already includes the new commitment transaction signature.The text was updated successfully, but these errors were encountered: