Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitcoin::secp256k1 over secp256k1_zkp #222

Closed
bennyhodl opened this issue May 31, 2024 · 4 comments
Closed

Use bitcoin::secp256k1 over secp256k1_zkp #222

bennyhodl opened this issue May 31, 2024 · 4 comments

Comments

@bennyhodl
Copy link
Contributor

As a pre-req to #221

I don't see a specific reason for using secp25k1_zkp

@Tibo-lg
Copy link
Contributor

Tibo-lg commented Jun 3, 2024

secp256k1_zkp is required to use the ecdsa_adaptor module so I don't think it's possible to use just secp256k1.

@bennyhodl
Copy link
Contributor Author

I think it would be worth while to convert everything besides the adaptor stuff. Ran into a lot of dependency issues when upgrading ₿itcoin with #223

@bennyhodl bennyhodl reopened this Jun 5, 2024
@Tibo-lg
Copy link
Contributor

Tibo-lg commented Jun 5, 2024

I don't think it's possible, the adaptor signature module uses the types from secp256k1 so if they're not from the same version it won't work.

@bennyhodl
Copy link
Contributor Author

Made a PR #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants