Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect @name annotation for key #366

Closed
mihaibudiu opened this issue Mar 18, 2017 · 3 comments
Closed

Incorrect @name annotation for key #366

mihaibudiu opened this issue Mar 18, 2017 · 3 comments
Labels
bug This behavior is unintended and should be fixed.

Comments

@mihaibudiu
Copy link
Contributor

See test p4_14_samples/simple_nat.p4 - the name generated for keys containing isValid() looks suspicious:

hdr.ipv4.isValid(): exact @name("hdr.ipv4.isValid()")

@mihaibudiu
Copy link
Contributor Author

@sethfowler : there are several issues related to naming things in the control-plane, including this one, #582, #595, #486. Maybe we can try to coordinate and find a solution to all of them?

@sethfowler
Copy link
Contributor

Yeah, I agree. I have a couple of other tasks I need to complete first, but this is something we need to address soon if possible.

We put some of this stuff off while we discussed language changes that unfortunately didn't end up materializing.

@mihaibudiu
Copy link
Contributor Author

I am assuming that this issue can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This behavior is unintended and should be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants