Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terribly worded warning when field of an invalid header is written #4945

Open
kfcripps opened this issue Oct 5, 2024 · 0 comments
Open

Terribly worded warning when field of an invalid header is written #4945

kfcripps opened this issue Oct 5, 2024 · 0 comments
Assignees
@jphurl @oleg-ran-amd
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)

Comments

@kfcripps
Copy link
Contributor

kfcripps commented Oct 5, 2024 •
edited
Loading

The pna-dpdk-header-union-stack1.p4 program results in the following warning:

...
pna-dpdk-header-union-stack1.p4(37): [--Wwarn=ignore-prop] warning: Result of 'hdr.h2[0].data = 16w1' is not defined: Error: Reading field from invalid header
        hdr.h2[0].data = 1;
                       ^

We should not have phrasing such as "Error: ..." in warning messages imo.

This is just one example but I think other warnings also have "Error: ..." in them.
@kfcripps kfcripps added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Oct 5, 2024
@kfcripps kfcripps mentioned this issue Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphurl jphurl

@oleg-ran-amd oleg-ran-amd

Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jphurl @kfcripps @oleg-ran-amd