Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u.isValid() #598

Closed
jnfoster opened this issue May 10, 2017 · 3 comments
Closed

u.isValid() #598

jnfoster opened this issue May 10, 2017 · 3 comments
Labels
duplicate This issue or pull request is a duplicate.

Comments

@jnfoster
Copy link
Contributor

The spec now mandates an isValid() method for header unions. This needs implemented.
@mihaibudiu mihaibudiu added the duplicate This issue or pull request is a duplicate. label May 10, 2017
@mihaibudiu
Copy link
Contributor

This is subsumed by #561.

@mihaibudiu
Copy link
Contributor

What is the value of isValid() on an empty union?
I really think we should forbid empty unions, they are a nasty corner case with no practical value.

@jnfoster
Copy link
Contributor Author

I'm fine deleting this issue; I was only adding it because someone (you) said it should be done at the LDWG ;-)

If u is an empty union, then u.isValid() is false. It's not an empty corner case. Following the definition given in the spec, it would be an empty disjunction, which is false (e.g., see https://en.wikipedia.org/wiki/Logical_disjunction).

-N

@fefer fefer mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request is a duplicate.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jnfoster @mihaibudiu